Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 447123002: No need to link base-unittests with GMock. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

No need to link base-unittests with GMock. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/base-unittests/base-unittests.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-07 04:47:39 UTC) #1
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-07 05:10:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-07 07:13:44 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-07 07:14:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 22954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698