Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: content/browser/renderer_host/compositing_iosurface_layer_mac.h

Issue 447113004: Fix crash in GotAcceleratedIOSurfaceFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositing_iosurface_layer_mac.h
diff --git a/content/browser/renderer_host/compositing_iosurface_layer_mac.h b/content/browser/renderer_host/compositing_iosurface_layer_mac.h
index b9d19da0ef4b860b9e849cc3ff7b9266a4743bb6..a01b6fc125ce6fa609b61c09ce6a7a8337a5e0bc 100644
--- a/content/browser/renderer_host/compositing_iosurface_layer_mac.h
+++ b/content/browser/renderer_host/compositing_iosurface_layer_mac.h
@@ -22,8 +22,17 @@ class CompositingIOSurfaceContext;
// BrowserCompositorViewMac).
class CompositingIOSurfaceLayerClient {
public:
+ // Used to indicate that the layer should attempt to draw immediately and
+ // should (even if the draw is elided by the system), ack the frame
+ // immediately.
virtual bool AcceleratedLayerShouldAckImmediately() const = 0;
- virtual void AcceleratedLayerDidDrawFrame(bool succeeded) = 0;
+
+ // Called when a frame is drawn or when, because the layer is not visible, it
+ // is known that the frame will never drawn.
+ virtual void AcceleratedLayerDidDrawFrame() = 0;
+
+ // Called when an error prevents the frame from being drawn.
+ virtual void AcceleratedLayerHitError() = 0;
};
// CompositingIOSurfaceLayerHelper provides C++ functionality needed for the

Powered by Google App Engine
This is Rietveld 408576698