Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 447093004: Land Recent QUIC Changes. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar1, avd, Ian Swett, rjshade, wtc, jar (doing other things), Jana
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. QUIC: don't keep around state for streams created by a request w/no body. Waiting for a stream frame w/ FIN that will never arrive, and the closed stream map grows without bound. Not flag protected. Merge internal change: 72338396 https://codereview.chromium.org/447093002/ Default socket receive buffer to 256K bytes and remove unnecessary CongestionFeedbackFrames from tests. Merge internal change: 72338299 https://codereview.chromium.org/447083002/ Include the socket receive buffer in the connection handshake. PRESENCE_OPTIONAL The goal is to eventually remove the TcpCongestionFeedbackFrame. Currently this sends the same value for every packet. All it contains is the tcp_receive_window (now called socket_receive_buffer) which is fixed at 256000. So it can be sent in the connection establishment and then never retransmitted. Because only one type of CongestionFeedbackFrame can be sent with an ack, this frees up space for a TimestampFrame which is the motivation for removing the TcpCongestionFeedbackFrame. Merge internal change: 72334240 https://codereview.chromium.org/446283002/ Improve QUIC's SendAlgorithmSimulator to allow setting the delayed ack timer and add a new test of a second BBR flow starting after a first flow has stabilized. Merge internal change: 72332690 https://codereview.chromium.org/449713002/ QUIC congestion option that forces ICWND to 10. Not flag protected. Merge internal change: 72323017 https://codereview.chromium.org/446253002/ Allow receiving a QUIC CongestionFeedbackFrame that is not kTCP. Currently the only congestion feedback frames that are sent are TCP, but I want to send timestamp packets in the next version, so the send algorithms should not assume that the incoming congestion feedback frame is kTCP. Merge internal change: 72322097 https://codereview.chromium.org/443313002/ QUIC - minor cleanup to match internal source tree. * Formatting cleanup and .get() != NULL changes. Merge internal change: 72204223 https://codereview.chromium.org/447973004/ Bring back InterArrivalReceiver and rename it to TimestampeReceiver. This is not in production. Merge internal change: 72170964 https://codereview.chromium.org/449693002/ Move Quic AppendTimestampFrame method out of AppendCongestionFrame. Also, remove obsolete TODO's and rename InterArrival to Timestamp. Not used in production. Merge internal change: 72148809 https://codereview.chromium.org/446063005/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288247

Patch Set 1 #

Patch Set 2 : fixed indenation in QuicFramer.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -214 lines) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/hybrid_slow_start_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/receive_algorithm_interface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.h View 3 chunks +17 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.cc View 7 chunks +77 lines, -48 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 4 chunks +21 lines, -7 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 12 chunks +9 lines, -55 lines 0 comments Download
A net/quic/congestion_control/timestamp_receiver.h View 1 chunk +37 lines, -0 lines 0 comments Download
A net/quic/congestion_control/timestamp_receiver.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A net/quic/congestion_control/timestamp_receiver_test.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_config.h View 2 chunks +12 lines, -0 lines 0 comments Download
M net/quic/quic_config.cc View 4 chunks +23 lines, -1 line 0 comments Download
M net/quic/quic_config_test.cc View 9 chunks +15 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 1 8 chunks +60 lines, -61 lines 0 comments Download
M net/quic/quic_framer_test.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M net/quic/quic_protocol.h View 4 chunks +9 lines, -6 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-07 01:47:52 UTC) #1
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-07 18:45:25 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 4 months ago (2014-08-07 19:27:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/447093004/1
6 years, 4 months ago (2014-08-07 19:35:21 UTC) #4
ramant (doing other things)
The CQ bit was unchecked by rtenneti@chromium.org
6 years, 4 months ago (2014-08-07 21:21:15 UTC) #5
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 4 months ago (2014-08-07 21:49:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/447093004/20001
6 years, 4 months ago (2014-08-07 22:20:41 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 08:10:23 UTC) #8
Message was sent while issue was closed.
Change committed as 288247

Powered by Google App Engine
This is Rietveld 408576698