Issue 447003002: Fix reference counting on SkStream in SkFontMgr_android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 447003002: Fix reference counting on SkStream in SkFontMgr_android. (Closed)

Created:
6 years, 4 months ago by bungeman-skia

Modified:
6 years, 4 months ago

Reviewers:
tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	src/ports/SkFontMgr_android.cpp	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Total messages: 6 (0 generated)

tomhudson

lgtm Appears to fix my crash bug on Android dm with FontMgr turned on. Thanks!

6 years, 4 months ago (2014-08-06 19:42:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/447003002/1

6 years, 4 months ago (2014-08-06 19:43:28 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia ...

6 years, 4 months ago (2014-08-06 20:18:28 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-06 20:21:03 UTC) #6

Message was sent while issue was closed.

Change committed as 8560cd5396f8902322471b49ac33aa849659228e