Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 446953002: Add an opaqueness hint to GrDrawState. (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@greg
Visibility:
Public.

Description

Add an opaqueness hint to GrDrawState. Check it when deciding whether to combine draw states. Committed: https://skia.googlesource.com/skia/+/62c447d3a556e3042cdf5d23b3e2a618eaa3c100

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : remove whitespace at end of line #

Total comments: 6

Patch Set 4 : rebase #

Patch Set 5 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -157 lines) Patch
M src/gpu/GrBitmapTextContext.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 2 3 4 10 chunks +47 lines, -48 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 3 4 9 chunks +57 lines, -14 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 1 chunk +2 lines, -21 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +1 line, -15 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 4 chunks +35 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
6 years, 4 months ago (2014-08-06 17:56:24 UTC) #1
egdaniel
lgtm + 2 nits https://codereview.chromium.org/446953002/diff/40001/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.chromium.org/446953002/diff/40001/src/gpu/GrDrawState.cpp#newcode510 src/gpu/GrDrawState.cpp:510: // (0,1). The same applies ...
6 years, 4 months ago (2014-08-06 19:42:31 UTC) #2
robertphillips
lgtm + comment request https://codereview.chromium.org/446953002/diff/40001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/446953002/diff/40001/src/gpu/GrDrawState.h#newcode767 src/gpu/GrDrawState.h:767: /// @name Hints More info ...
6 years, 4 months ago (2014-08-06 20:29:12 UTC) #3
bsalomon
https://codereview.chromium.org/446953002/diff/40001/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.chromium.org/446953002/diff/40001/src/gpu/GrDrawState.cpp#newcode510 src/gpu/GrDrawState.cpp:510: // (0,1). The same applies when coverage is known ...
6 years, 4 months ago (2014-08-08 15:00:13 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-08 15:00:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/446953002/80001
6 years, 4 months ago (2014-08-08 15:01:58 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 15:08:57 UTC) #7
Message was sent while issue was closed. 
Change committed as 62c447d3a556e3042cdf5d23b3e2a618eaa3c100

Powered by Google App Engine
This is Rietveld 408576698