Chromium Code Reviews Chromium Code Reviews
Issue 446933002:
make the action buttons for rebaseline server stick to the top of the window as you scroll (Closed)
Base URL: https://skia.googlesource.com/skia.git@master| Index: gm/rebaseline_server/static/view.html |
| diff --git a/gm/rebaseline_server/static/view.html b/gm/rebaseline_server/static/view.html |
| index 0e964d1e980a3d106f01f2e6db00f44a54a95fe1..3cf59627873ac09c0f54dcb03dd42d637a95dbab 100644 |
| --- a/gm/rebaseline_server/static/view.html |
| +++ b/gm/rebaseline_server/static/view.html |
| @@ -4,9 +4,11 @@ |
| <head> |
| <title ng-bind="windowTitle"></title> |
| + <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script> |
|
epoger
2014/08/06 17:14:11
Why do we need to import jquery in addition to ang
humper
2014/08/06 17:32:12
discussed in person, Stephan says it's fine
|
| <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js"></script> |
| <script src="constants.js"></script> |
| <script src="loader.js"></script> |
|
epoger
2014/08/06 17:14:11
All changes in this file also need to be made to l
humper
2014/08/06 17:32:12
Done.
|
| + <script src="rebaseline_server.js"></script> |
| <link rel="stylesheet" href="view.css"> |
| </head> |
| @@ -195,46 +197,43 @@ |
| <p> |
| + <div class="results-header"> <!-- results header --> |
| + <div class="results-header-actions"> |
| + all tests shown: |
| + <button ng-click="selectAllImagePairs()"> |
| + select |
| + </button> |
| + <button ng-click="clearAllImagePairs()"> |
| + clear |
| + </button> |
| + <button ng-click="toggleAllImagePairs()"> |
| + toggle |
| + </button> |
| + <div ng-repeat="otherTab in tabs"> |
| + <button ng-click="moveSelectedImagePairsToTab(otherTab)" |
| + ng-disabled="selectedImagePairs.length == 0" |
| + ng-show="otherTab != viewingTab"> |
| + move {{selectedImagePairs.length}} selected tests to {{otherTab}} tab |
| + </button> |
| + </div> |
| + </div> |
| + <div class="results-header-stats"> |
| + Found {{filteredImagePairs.length}} matches; |
| + <span ng-show="filteredImagePairs.length > limitedImagePairs.length"> |
| + displaying the first {{limitedImagePairs.length}}. |
| + </span> |
| + <span ng-show="filteredImagePairs.length <= limitedImagePairs.length"> |
| + displaying them all. |
| + </span> |
| + <span ng-show="renderEndTime > renderStartTime"> |
| + Rendered in {{(renderEndTime - renderStartTime).toFixed(0)}} ms. |
| + </span> |
| + <br> |
| + (click on the column header radio buttons to re-sort by that column) |
| + </div> |
| + </div> <!-- results header --> |
| + |
| <table border="0"><tr><td> <!-- table holding results header + results table --> |
| - <table border="0" width="100%"> <!-- results header --> |
| - <tr> |
| - <td> |
| - Found {{filteredImagePairs.length}} matches; |
| - <span ng-show="filteredImagePairs.length > limitedImagePairs.length"> |
| - displaying the first {{limitedImagePairs.length}}. |
| - </span> |
| - <span ng-show="filteredImagePairs.length <= limitedImagePairs.length"> |
| - displaying them all. |
| - </span> |
| - <span ng-show="renderEndTime > renderStartTime"> |
| - Rendered in {{(renderEndTime - renderStartTime).toFixed(0)}} ms. |
| - </span> |
| - <br> |
| - (click on the column header radio buttons to re-sort by that column) |
| - </td> |
| - <td align="right"> |
| - <div> |
| - all tests shown: |
| - <button ng-click="selectAllImagePairs()"> |
| - select |
| - </button> |
| - <button ng-click="clearAllImagePairs()"> |
| - clear |
| - </button> |
| - <button ng-click="toggleAllImagePairs()"> |
| - toggle |
| - </button> |
| - </div> |
| - <div ng-repeat="otherTab in tabs"> |
| - <button ng-click="moveSelectedImagePairsToTab(otherTab)" |
| - ng-disabled="selectedImagePairs.length == 0" |
| - ng-show="otherTab != viewingTab"> |
| - move {{selectedImagePairs.length}} selected tests to {{otherTab}} tab |
| - </button> |
| - </div> |
| - </td> |
| - </tr> |
| - </table> <!-- results header --> |
| </td></tr><tr><td> |
| <table border="1" ng-app="diff_viewer"> <!-- results --> |
| <tr> |
