make the action buttons for rebaseline server stick to the top of the window as you scroll

make the action buttons for rebaseline server stick to the top of the window as you scroll

NOTRY=true

BUG=skia:1912
Committed: https://skia.googlesource.com/skia/+/27ff22758958c26759187b7f4060fad1ed4b62b7

[humper, 2014-08-06 17:01:37]

PTAL it's so pretty

[humper, 2014-08-06 17:04:36]

The CQ bit was checked by humper@google.com

[humper, 2014-08-06 17:04:36]

The CQ bit was unchecked by humper@google.com

[humper, 2014-08-06 17:05:22]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-06 17:06:17]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/446933002/1

[epoger, 2014-08-06 17:14:11]

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:295: $timeout( function() {
please add the same call to live-loader.js (which will subsume loader.js, I'm in
the midst of that process right now)

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/rebaseline_server.js (right):

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/rebaseline_server.js:1: function
make_results_header_sticky( ) {
Why is this function in its own new file?

(I'm in favor of breaking up loader.json into smaller pieces, but I think it
would be a good idea to be mindful of how we rearrange it.)

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/view.html:7: <script
src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
Why do we need to import jquery in addition to angularjs?  angularjs should
probably be sufficient... seems awfully heavyweight for one more small feature.

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/view.html:10: <script src="loader.js"></script>
All changes in this file also need to be made to live-view.html (which will
subsume view.html, like how live-loader.js is taking over loader.js)

[epoger, 2014-08-06 17:14:16]

The CQ bit was unchecked by epoger@google.com

[humper, 2014-08-06 17:32:12]

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:295: $timeout( function() {
On 2014/08/06 17:14:11, epoger wrote:
> please add the same call to live-loader.js (which will subsume loader.js, I'm
in
> the midst of that process right now)

Done.

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/rebaseline_server.js (right):

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/rebaseline_server.js:1: function
make_results_header_sticky( ) {
On 2014/08/06 17:14:11, epoger wrote:
> Why is this function in its own new file?
> 
> (I'm in favor of breaking up loader.json into smaller pieces, but I think it
> would be a good idea to be mindful of how we rearrange it.)

Discussed in person; renamed file.

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/view.html:7: <script
src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
On 2014/08/06 17:14:11, epoger wrote:
> Why do we need to import jquery in addition to angularjs?  angularjs should
> probably be sufficient... seems awfully heavyweight for one more small
feature.

discussed in person, Stephan says it's fine

https://codereview.chromium.org/446933002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/view.html:10: <script src="loader.js"></script>
On 2014/08/06 17:14:11, epoger wrote:
> All changes in this file also need to be made to live-view.html (which will
> subsume view.html, like how live-loader.js is taking over loader.js)

Done.

[humper, 2014-08-06 17:34:41]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-06 17:35:45]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/446933002/20002

[epoger, 2014-08-06 17:49:20]

Seems fine to me.  I will let Stephan enter the magic 4 characters as he sees
fit.

[stephana, 2014-08-06 17:53:13]

On 2014/08/06 17:49:20, epoger wrote:
> Seems fine to me.  I will let Stephan enter the magic 4 characters as he sees
> fit.

LGTM

[humper, 2014-08-06 18:03:48]

The CQ bit was unchecked by humper@google.com

[humper, 2014-08-06 18:03:49]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-06 18:03:58]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/446933002/20002

[epoger, 2014-08-06 18:34:51]

LGTM

Looking at
https://skia-tree-status.appspot.com/cq/humper@google.com/446933002/20002 , it
seems that Stephan is not a valid reviewer yet?

Wed Aug 06, 18:04 UTC	why not	
reviewer_lgtm: Waiting for LGTM from a valid reviewer till 2014-08-06 21:03 UTC

Maybe my LGTM will unlock it?

[epoger, 2014-08-06 18:42:43]

On 2014/08/06 18:34:51, epoger wrote:
> LGTM
> 
> Looking at
> https://skia-tree-status.appspot.com/cq/humper@google.com/446933002/20002 , it
> seems that Stephan is not a valid reviewer yet?
> 
> Wed Aug 06, 18:04 UTC	why not	
> reviewer_lgtm: Waiting for LGTM from a valid reviewer till 2014-08-06 21:03
UTC
> 
> Maybe my LGTM will unlock it?

Actually, looking at chrome-build-alerts emails, I guess the CommitQueue is just
stuck right now. :-(

[humper, 2014-08-06 19:39:48]

The CQ bit was unchecked by humper@google.com

[humper, 2014-08-06 19:39:51]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-06 19:39:54]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/446933002/20002

[commit-bot: I haz the power, 2014-08-06 19:40:04]

Change committed as 27ff22758958c26759187b7f4060fad1ed4b62b7