Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 446923002: Get rid of the "spare buffer" cache. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Get rid of the "spare buffer" cache. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22943

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -52 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M src/arm64/assembler-arm64.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M src/assembler.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-06 16:44:28 UTC) #1
Igor Sheludko
lgtm https://codereview.chromium.org/446923002/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/446923002/diff/1/src/arm/assembler-arm.cc#newcode3227 src/arm/assembler-arm.cc:3227: // Switch buffers. Obsolete comment. https://codereview.chromium.org/446923002/diff/1/src/arm64/assembler-arm64.cc File src/arm64/assembler-arm64.cc ...
6 years, 4 months ago (2014-08-06 16:52:08 UTC) #2
Toon Verwaest
Committed patchset #1 manually as 22943 (presubmit successful).
6 years, 4 months ago (2014-08-06 16:57:02 UTC) #3
Sven Panne
Nice! This has been on my ToDo list for ages, and I almost forgot it. ...
6 years, 4 months ago (2014-08-07 06:47:48 UTC) #4
Benedikt Meurer
6 years, 4 months ago (2014-08-07 06:54:07 UTC) #5
Message was sent while issue was closed.
On 2014/08/07 at 06:47:48, svenpanne wrote:
> Nice! This has been on my ToDo list for ages, and I almost forgot it. :-)
After this, I think it's worthwhile to disentangle the Assembler and Isolate
further: Conceptually, there is no need for an Isolate to assemble something,
but I fear that Assembler (just like Zone) is often abused to pass around the
Isolate. Anyway, breaking this dependency would make unit testing things much
easier.

s/much easier/possible/

Powered by Google App Engine
This is Rietveld 408576698