Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 446893003: [SyncFS] Ensure to pass DB in some utilities (Closed)

Created:
6 years, 4 months ago by peria
Modified:
6 years, 4 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Ensure to pass DB in some utilities BUG=None TEST=./unit_tests --gtest_filter="DriveMetadata*:DriveBackend*:Metadata*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288025

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Work for nits #

Total comments: 2

Patch Set 3 : work for a nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -52 lines) Patch
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc View 1 2 2 chunks +62 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
peria
PTL
6 years, 4 months ago (2014-08-07 05:21:19 UTC) #1
tzik
lgtm
6 years, 4 months ago (2014-08-07 06:30:42 UTC) #2
nhiroki
https://codereview.chromium.org/446893003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc (right): https://codereview.chromium.org/446893003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc#newcode70 chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc:70: virtual void SetUp() { Please mark this with OVERRIDE. ...
6 years, 4 months ago (2014-08-07 06:34:27 UTC) #3
peria
The CQ bit was checked by peria@chromium.org
6 years, 4 months ago (2014-08-07 06:36:13 UTC) #4
peria
The CQ bit was unchecked by peria@chromium.org
6 years, 4 months ago (2014-08-07 06:36:15 UTC) #5
peria
https://codereview.chromium.org/446893003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc (right): https://codereview.chromium.org/446893003/diff/40001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc#newcode70 chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc:70: virtual void SetUp() { On 2014/08/07 06:34:26, nhiroki wrote: ...
6 years, 4 months ago (2014-08-07 07:10:52 UTC) #6
nhiroki
lgtm with a nit. https://codereview.chromium.org/446893003/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc (right): https://codereview.chromium.org/446893003/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc#newcode5 chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc:5: #include "base/files/scoped_temp_dir.h" nit: This is ...
6 years, 4 months ago (2014-08-07 07:14:01 UTC) #7
peria
https://codereview.chromium.org/446893003/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc (right): https://codereview.chromium.org/446893003/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc#newcode5 chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc:5: #include "base/files/scoped_temp_dir.h" On 2014/08/07 07:14:01, nhiroki wrote: > nit: ...
6 years, 4 months ago (2014-08-07 07:19:34 UTC) #8
peria
The CQ bit was checked by peria@chromium.org
6 years, 4 months ago (2014-08-07 07:19:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/446893003/100001
6 years, 4 months ago (2014-08-07 07:20:58 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 10:10:56 UTC) #11
Message was sent while issue was closed. 
Change committed as 288025

Powered by Google App Engine
This is Rietveld 408576698