Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 446853002: Fix invalid array access in OnRobustJPEGDecodeImage(). (Closed)

Created:
6 years, 4 months ago by Thiemo Nagel
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix invalid array access in OnRobustJPEGDecodeImage(). This doesn't seem to be a problem for release builds, but in debug builds the invalid array access causes STL errors: error: attempt to subscript container with out-of-bounds index 0, but container only holds 0 elements. BUG=401161 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Thiemo Nagel
Hi Lei, could you please take a look? Thank you and best regards, Thiemo
6 years, 4 months ago (2014-08-06 13:16:50 UTC) #1
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-06 18:38:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/446853002/1
6 years, 4 months ago (2014-08-06 18:39:37 UTC) #3
Thiemo Nagel
On 2014/08/06 18:38:38, Lei Zhang wrote: > lgtm Thank you!
6 years, 4 months ago (2014-08-06 19:26:32 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 22:54:19 UTC) #5
Message was sent while issue was closed.
Change committed as 287884

Powered by Google App Engine
This is Rietveld 408576698