Browser Test: Autocomplete confused about direction if inline style and inherited dir attribute…

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
@@ skipping 663 matching lines @@
     if (test_cases[i].form_control_type == "text")
       expected.max_length = WebInputElement::defaultMaxLength();
     else
       expected.max_length = 0;
 
     SCOPED_TRACE(test_cases[i].element_id);
     EXPECT_FORM_FIELD_DATA_EQUALS(expected, result);
   }
 }
 
+// Both text input and autocomplete should have same direction.
+TEST_F(FormAutofillTest,
+  WebFormControlElementToFormFieldAutocompleteDirection) {

[Ilya Sherman, 2014/08/06 20:45:21]

nit: This line should be indented more, like so:

TEST_F(FormAutofillTest,
       WebFormControlElementToFormFieldAutocompleteDirection) {

+  WebFrame* frame = NULL;
+  LoadHTML("<STYLE>input{direction:rtl}</STYLE>"
+           "<FORM autocomplete=\"on\">"
+           " <INPUT type=\"text\" id=\"element\" value=\"RTL\"/>"

[Ilya Sherman, 2014/08/06 20:45:21]

nit: It might be cleaner to use single quotes to surround attribute values,
rather than double quotes, since single quotes don't need to be escaped.  (I
realize that the existing tests use double quotes.  It would be great to clean
this up at some point :)

[Ilya Sherman, 2014/08/06 20:45:21]

nit: Please indent by two spaces, rather than by one.  Ditto below.

+           "</FORM>");
+
+  frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
+
+  WebElement web_element = frame->document().getElementById("element");
+  WebFormControlElement element = web_element.to<WebFormControlElement>();
+
+  FormFieldData result1;
+  WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result1);
+  EXPECT_EQ(base::i18n::RIGHT_TO_LEFT, result1.text_direction);
+
+  LoadHTML("<STYLE>span{direction:rtl}</STYLE>"
+           "<FORM autocomplete=\"on\">"
+           " <SPAN>"
+           "  <INPUT type=\"text\" id=\"element\" value=\"RTL\"/>"
+           " </SPAN>"
+           "</FORM>");

[Ilya Sherman, 2014/08/06 20:45:21]

Please write separate TEST_F test cases for each HTML form, rather than grouping
them all into a single tests.  Short test cases are easier to understand and to
maintain.  (Again, I realize the existing code is not always good about
following this practice; again, this is something that would be good to clean up
in this file :)

+
+  frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
+
+  web_element = frame->document().getElementById("element");
+  element = web_element.to<WebFormControlElement>();
+  FormFieldData result2;
+  WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result2);
+  EXPECT_EQ(base::i18n::RIGHT_TO_LEFT, result2.text_direction);
+
+  LoadHTML("<FORM autocomplete=\"on\">"
+           " <SPAN>"
+           "  <INPUT dir=\"rtl\" type=\"text\" id=\"element\" value=\"RTL\"/>"
+           " </SPAN>"
+           "</FORM>");
+
+  frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
+
+  web_element = frame->document().getElementById("element");
+  element = web_element.to<WebFormControlElement>();
+  FormFieldData result3;
+  WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result3);
+  EXPECT_EQ(base::i18n::RIGHT_TO_LEFT, result3.text_direction);
+
+  LoadHTML("<STYLE>input{direction:ltr}</STYLE>"
+           "<FORM dir=\"rtl\" autocomplete=\"on\">"
+           " <INPUT type=\"text\" id=\"element\" value=\"LTR\"/>"
+           "</FORM>");
+
+  frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
+
+  web_element = frame->document().getElementById("element");
+  element = web_element.to<WebFormControlElement>();
+  FormFieldData result4;
+  WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result4);
+  EXPECT_EQ(base::i18n::LEFT_TO_RIGHT, result4.text_direction);
+
+  LoadHTML("<STYLE>span{direction:ltr}</STYLE>"
+           "<FORM autocomplete=\"on\">"
+           " <SPAN dir=\"rtl\">"
+           "  <INPUT type=\"text\" id=\"element\" value=\"LTR\"/>"
+           " </SPAN>"
+           "</FORM>");
+
+  frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
+
+  web_element = frame->document().getElementById("element");
+  element = web_element.to<WebFormControlElement>();
+  FormFieldData result5;
+  WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result5);
+  EXPECT_EQ(base::i18n::LEFT_TO_RIGHT, result5.text_direction);
+
+  LoadHTML("<BODY dir=\"rtl\">"
+           "<FORM style=\"direction:ltr\" autocomplete=\"on\">"
+           " <SPAN dir=\"rtl\">"
+           "  <INPUT dir=\"ltr\" type=\"text\" id=\"element\" value=\"LTR\"/>"
+           " </SPAN>"
+           "</FORM>");
+
+  frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
+
+  web_element = frame->document().getElementById("element");
+  element = web_element.to<WebFormControlElement>();
+  FormFieldData result6;
+  WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result6);
+  EXPECT_EQ(base::i18n::LEFT_TO_RIGHT, result6.text_direction);
+}
+
 TEST_F(FormAutofillTest, WebFormElementToFormData) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            " <LABEL for=\"firstname\">First name:</LABEL>"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"John\"/>"
            " <LABEL for=\"lastname\">Last name:</LABEL>"
            "  <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            " <LABEL for=\"street-address\">Address:</LABEL>"
            "  <TEXTAREA id=\"street-address\">"
                "123 Fantasy Ln.&#10;"
                "Apt. 42"
@@ skipping 2868 matching lines @@
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("country");
   expected.value = ASCIIToUTF16("AL");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
 }  // namespace autofill