Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 446833002: Revert of Enable Android lint by default (Closed)

Created:
6 years, 4 months ago by aberent
Modified:
6 years, 4 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable Android lint by default (https://codereview.chromium.org/396293002/) Reason for revert: Two Android build bots (downstream) are failing as a result of this CL. Reverting as Android Build Sheriff. BUG=401020 TBR=cjhopman NOTRY=true Original issue's description: > Enable Android lint by default > > BUG=393235 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287676 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M build/android/buildbot/bb_run_bot.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/lint.py View 2 chunks +5 lines, -12 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
aberent
Created Revert of Enable Android lint by default
6 years, 4 months ago (2014-08-06 10:20:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/446833002/1
6 years, 4 months ago (2014-08-06 10:20:58 UTC) #2
aberent
The CQ bit was unchecked by aberent@chromium.org
6 years, 4 months ago (2014-08-06 10:24:17 UTC) #3
aberent
The CQ bit was checked by aberent@chromium.org
6 years, 4 months ago (2014-08-06 10:24:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/446833002/1
6 years, 4 months ago (2014-08-06 10:24:53 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 10:26:15 UTC) #6
Message was sent while issue was closed.
Change committed as 287751

Powered by Google App Engine
This is Rietveld 408576698