[SyncFS] Unconditionally demote remote file trackers on remote-to-local sync

chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc

Index: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc
index a40908a733ca58522855ebc42a5c531fb8e02cf7..d37b6f90c358e88171e0c6ef01e6da46dedeeb22 100644
--- a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc
+++ b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc
@@ -189,10 +189,17 @@ class RemoteToLocalSyncerTest : public testing::Test {
     return status;
   }
 
-  void RunSyncerUntilIdle() {
+  SyncStatusCode RunSyncerUntilIdle() {
+    const int kRetryLimit = 100;
     SyncStatusCode status = SYNC_STATUS_UNKNOWN;
-    while (status != SYNC_STATUS_NO_CHANGE_TO_SYNC)
+    int count = 0;
+    do {
+      if (count++ > kRetryLimit)
+        return status;
       status = RunSyncer();
+    } while (status == SYNC_STATUS_OK ||
+             status == SYNC_STATUS_RETRY);
+    return status;
   }
 
   SyncStatusCode ListChanges() {
@@ -244,7 +251,7 @@ TEST_F(RemoteToLocalSyncerTest, AddNewFile) {
   const std::string folder2 = CreateRemoteFolder(folder1, "folder2");
   const std::string file2 = CreateRemoteFile(folder1, "file2", "data2");
 
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
 
   // Create expected changes.
   // TODO(nhiroki): Clean up creating URL part.
@@ -283,7 +290,7 @@ TEST_F(RemoteToLocalSyncerTest, DeleteFile) {
                        FileChange::FILE_CHANGE_ADD_OR_UPDATE,
                        SYNC_FILE_TYPE_FILE);
 
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   DeleteRemoteFile(folder);
@@ -297,7 +304,7 @@ TEST_F(RemoteToLocalSyncerTest, DeleteFile) {
                        SYNC_FILE_TYPE_UNKNOWN);
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   EXPECT_FALSE(GetMetadataDatabase()->HasDirtyTracker());
@@ -328,7 +335,7 @@ TEST_F(RemoteToLocalSyncerTest, DeleteNestedFiles) {
                        FileChange::FILE_CHANGE_ADD_OR_UPDATE,
                        SYNC_FILE_TYPE_FILE);
 
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   DeleteRemoteFile(folder1);
@@ -339,7 +346,7 @@ TEST_F(RemoteToLocalSyncerTest, DeleteNestedFiles) {
   // Changes for descendant files ("folder2" and "file2") should be ignored.
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   EXPECT_FALSE(GetMetadataDatabase()->HasDirtyTracker());
@@ -358,10 +365,10 @@ TEST_F(RemoteToLocalSyncerTest, Conflict_CreateFileOnFolder) {
   // Folder-File conflict happens. File creation should be ignored.
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
-  // Tracker for the remote file should be lowered.
+  // Tracker for the remote file should has low priority.
   EXPECT_FALSE(GetMetadataDatabase()->GetNormalPriorityDirtyTracker(NULL));
   EXPECT_TRUE(GetMetadataDatabase()->HasLowPriorityDirtyTracker());
 }
@@ -373,7 +380,7 @@ TEST_F(RemoteToLocalSyncerTest, Conflict_CreateFolderOnFile) {
   InitializeMetadataDatabase();
   RegisterApp(kOrigin.host(), app_root);
 
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   CreateLocalFile(URL(kOrigin, "file"));
@@ -385,7 +392,7 @@ TEST_F(RemoteToLocalSyncerTest, Conflict_CreateFolderOnFile) {
                        SYNC_FILE_TYPE_DIRECTORY);
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   EXPECT_FALSE(GetMetadataDatabase()->HasDirtyTracker());
@@ -404,7 +411,7 @@ TEST_F(RemoteToLocalSyncerTest, Conflict_CreateFolderOnFolder) {
   // Folder-Folder conflict happens. Folder creation should be ignored.
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   EXPECT_FALSE(GetMetadataDatabase()->HasDirtyTracker());
@@ -423,7 +430,7 @@ TEST_F(RemoteToLocalSyncerTest, Conflict_CreateFileOnFile) {
   // File-File conflict happens. File creation should be ignored.
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   // Tracker for the remote file should be lowered.
@@ -438,7 +445,7 @@ TEST_F(RemoteToLocalSyncerTest, Conflict_CreateNestedFolderOnFile) {
   InitializeMetadataDatabase();
   RegisterApp(kOrigin.host(), app_root);
 
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   const std::string folder = CreateRemoteFolder(app_root, "folder");
@@ -451,7 +458,8 @@ TEST_F(RemoteToLocalSyncerTest, Conflict_CreateNestedFolderOnFile) {
                        SYNC_FILE_TYPE_DIRECTORY);
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_FILE_ERROR_NOT_A_DIRECTORY, RunSyncerUntilIdle());
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 }
 
@@ -462,7 +470,7 @@ TEST_F(RemoteToLocalSyncerTest, AppRootDeletion) {
   InitializeMetadataDatabase();
   RegisterApp(kOrigin.host(), app_root);
 
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   DeleteRemoteFile(app_root);
@@ -472,7 +480,7 @@ TEST_F(RemoteToLocalSyncerTest, AppRootDeletion) {
                        SYNC_FILE_TYPE_UNKNOWN);
 
   EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
-  RunSyncerUntilIdle();
+  EXPECT_EQ(SYNC_STATUS_NO_CHANGE_TO_SYNC, RunSyncerUntilIdle());
   VerifyConsistency();
 
   // SyncEngine will re-register the app and resurrect the app root later.