[SyncFS] Unconditionally demote remote file trackers on remote-to-local sync

[SyncFS] Unconditionally demote remote file trackers on remote-to-local sync

Keep trackers demoted when it is being synced from local to remote, so that the tracker is not chosen for another LocalToRemoteSyncer instance.

BUG=344769
TEST=unit_tests --gtest_filter=LocalToRemoteSyncerTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289212

[tzik, 2014-08-07 09:12:01]

PTL

[peria, 2014-08-07 09:24:48]

https://codereview.chromium.org/446793002/diff/60001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/446793002/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1179: bool
should_promote = false;
isn't it referred?

[tzik, 2014-08-08 04:05:43]

https://codereview.chromium.org/446793002/diff/60001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/446793002/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1179: bool
should_promote = false;
On 2014/08/07 09:24:48, peria wrote:
> isn't it referred?

Ah, I forgot to check it. Fixed.

[peria, 2014-08-08 04:07:02]

lgtm

[tzik, 2014-08-08 04:15:12]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-08-08 04:15:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/446793002/80001

[commit-bot: I haz the power, 2014-08-08 07:55:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-08 08:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 08:27:34]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2014-08-12 13:32:19]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-08-12 13:33:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/446793002/100001

[commit-bot: I haz the power, 2014-08-12 18:15:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 18:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 18:29:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tzik, 2014-08-13 04:37:17]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-08-13 04:38:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/446793002/120001

[commit-bot: I haz the power, 2014-08-13 08:27:01]

Change committed as 289212