Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 446743002: Revert of Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none ... (Closed)

Created:
6 years, 4 months ago by robliao
Modified:
6 years, 4 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org, Ryan Hamilton
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (ht… (https://codereview.chromium.org/444453002/) Reason for revert: Macbots are getting stuck here: [ OK ] page_runner_unittest.PageRunnerTests.testDiscardFirstResult (10464 ms) [ RUN ] page_runner_unittest.PageRunnerTests.testHandlingOfCrashedTab [ RUN ] chrome://crash http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.6%20Tests%20(3) http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.7%20Tests%20(3) Original issue's description: > Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/)" > > This reverts https://codereview.chromium.org/320693002/ > > The original regression this caused (PageRunnerTests.testHandlingOfCrashedTab in telemetry_unittests) does not seem to be happening anymore (locally or on trybots), but please revert and let me know if it happens on the main waterfall. > > TBR=tonyg,dtu > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287612 TBR=tonyg@chromium.org,dtu@chromium.org,oysteine@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -34 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +18 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robliao
Created Revert of Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab ...
6 years, 4 months ago (2014-08-06 00:05:50 UTC) #1
robliao
6 years, 4 months ago (2014-08-06 00:06:29 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 00:09:09 UTC) #3
Message was sent while issue was closed.
Change committed as 287652

Powered by Google App Engine
This is Rietveld 408576698