Support non-US layout for rewriting Numpad key events.

chrome/browser/chromeos/events/event_rewriter.cc

Index: chrome/browser/chromeos/events/event_rewriter.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc
index d7497c6ebae6c6b5f58284d0b37ff9d16c736088..2088a51d4f085c9e9bafc41721ae2734dca02154 100644
--- a/chrome/browser/chromeos/events/event_rewriter.cc
+++ b/chrome/browser/chromeos/events/event_rewriter.cc
@@ -212,6 +212,7 @@ void EventRewriter::BuildRewrittenKeyEvent(
     else
       xkeyevent.xkey = xev->xkey;
 
+    unsigned int original_x11_keycode = xkeyevent.xkey.keycode;
     // Update native event to match rewritten |ui::Event|.
     // The X11 keycode represents a physical key position, so it shouldn't
     // change unless we have actually changed keys, not just modifiers.
@@ -222,6 +223,23 @@ void EventRewriter::BuildRewrittenKeyEvent(
     }
     ui::KeyEvent x11_key_event(&xkeyevent);
     rewritten_key_event = new ui::KeyEvent(x11_key_event);
+
+    // For numpad keys, the key char should always NOT be changed because
+    // XKeyCodeForWindowsKeyCode method cannot handle non-US keyboard layout.
+    // The correct key char can be got from original X11 keycode but not for the
+    // rewritten X11 keycode.
+    // For SHIFT+NumpadKey cases, use the rewritten X11 keycode (US layout).
+    // Please see crbug.com/335644.
+    if (key_code >= ui::VKEY_NUMPAD0 && key_code <= ui::VKEY_DIVIDE) {
+      XEvent numpad_xevent;
+      numpad_xevent.xkey = xkeyevent.xkey;
+      numpad_xevent.xkey.state &= ~ShiftMask;

[Yusuke Sato, 2014/08/08 06:00:32]

Please explain (as code comment) why we need to remove ShiftMask. I already know
because I chatted with you but other reviewers might not know.

[Shu Chen, 2014/08/08 06:35:13]

Done.

+      numpad_xevent.xkey.state |= Mod2Mask;

[Yusuke Sato, 2014/08/08 06:00:32]

Mention that Mod2Mask is NumLock to make the code easier to read?

[Shu Chen, 2014/08/08 06:35:13]

Done.

+      if (!(flags & ui::EF_SHIFT_DOWN))
+        numpad_xevent.xkey.keycode = original_x11_keycode;
+      rewritten_key_event->set_character(
+          ui::GetCharacterFromXEvent(&numpad_xevent));
+    }
   }
 #endif
   if (!rewritten_key_event)