[SyncFS] Rollback function from version 4 to version 3.

[SyncFS] Rollback function from version 4 to version 3.
Make a routine, but it is not called.


BUG=347425
TEST=./unit_tests --gtest_filter="DriveMetadata*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288012

[peria, 2014-08-07 04:22:08]

PTL.

[tzik, 2014-08-07 04:47:17]

lgtm

[peria, 2014-08-07 05:03:14]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-08-07 05:04:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/446653003/20001

[nhiroki, 2014-08-07 06:26:39]

Just a comment. You don't have to stop the CQ :)

https://codereview.chromium.org/446653003/diff/20001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc
(right):

https://codereview.chromium.org/446653003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc:349:
const char kDemotedDirtyIDKeyPrefix[] = "DEMOTED_DIRTY: ";
I'd prefer not to spread these constants across production code, migration
helper and tests. How about wrapping these constants with any namespace and
reusing it? For example...

class DBConstantsV4 {
  ...  // defined constants only used for V4.
};

Wdyt?

[peria, 2014-08-07 06:35:56]

On 2014/08/07 06:26:39, nhiroki wrote:
> Just a comment. You don't have to stop the CQ :)
> 
>
https://codereview.chromium.org/446653003/diff/20001/chrome/browser/sync_file...
> File
>
chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/446653003/diff/20001/chrome/browser/sync_file...
>
chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc:349:
> const char kDemotedDirtyIDKeyPrefix[] = "DEMOTED_DIRTY: ";
> I'd prefer not to spread these constants across production code, migration
> helper and tests. How about wrapping these constants with any namespace and
> reusing it? For example...
> 
> class DBConstantsV4 {
>   ...  // defined constants only used for V4.
> };
> 
> Wdyt?

I agree.
I also think that we need such namespace not to confuse coders.

[commit-bot: I haz the power, 2014-08-07 08:21:04]

Change committed as 288012