Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 446613003: Mark RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap as flaky under TSANv2. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc
===================================================================
--- content/browser/frame_host/render_frame_host_manager_browsertest.cc (revision 287590)
+++ content/browser/frame_host/render_frame_host_manager_browsertest.cc (working copy)
@@ -337,8 +337,17 @@
// Test for crbug.com/116192. Targeted links should still work after the
// named target window has swapped processes.
+//
+// Flaky under TSANv2. http://crbug.com/400850
+#if defined(THREAD_SANITIZER)
+#define MAYBE_AllowTargetedNavigationsAfterSwap \
+ DISABLED_AllowTargetedNavigationsAfterSwap
+#else
+#define MAYBE_AllowTargetedNavigationsAfterSwap \
+ AllowTargetedNavigationsAfterSwap
+#endif
IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
- AllowTargetedNavigationsAfterSwap) {
+ MAYBE_AllowTargetedNavigationsAfterSwap) {
StartServer();
// Load a page with links that open in a new window.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698