content/shell/renderer/test_runner/gamepad_controller.h - Issue 446603002: Refactor code listening to platform events in content/renderer/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/gamepad_controller.h

Issue 446603002: Refactor code listening to platform events in content/renderer/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webkitplatform_impl_start_stop

Patch Set: apply review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/renderer_webkitplatformsupport_impl.h ('K') | « content/renderer/renderer_webkitplatformsupport_impl.cc ('k') | content/shell/renderer/test_runner/gamepad_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/gamepad_controller.h

diff --git a/content/shell/renderer/test_runner/gamepad_controller.h b/content/shell/renderer/test_runner/gamepad_controller.h

index 99b7efc285598a6b40cbcd3b1caa5e5e8ef9e726..53338a80f098b3c36b4bd6737186c05ac4c68b37 100644

--- a/content/shell/renderer/test_runner/gamepad_controller.h

+++ b/content/shell/renderer/test_runner/gamepad_controller.h

@@ -34,8 +34,9 @@ class GamepadController

// RendererGamepadProvider implementation.

virtual void SampleGamepads(

blink::WebGamepads& gamepads) OVERRIDE;

- virtual void SetGamepadListener(

- blink::WebGamepadListener* listener) OVERRIDE;

+ virtual bool OnControlMessageReceived(const IPC::Message& msg) OVERRIDE;

+ virtual void SendStartMessage() OVERRIDE;

+ virtual void SendStopMessage() OVERRIDE;

private:

friend class GamepadControllerBindings;

@@ -58,8 +59,6 @@ class GamepadController

blink::WebGamepads gamepads_;

- blink::WebGamepadListener* listener_;

// Mapping from gamepad index to connection state.

std::map<int, bool> pending_changes_;