content/renderer/device_sensors/device_orientation_event_pump_unittest.cc - Issue 446603002: Refactor code listening to platform events in content/renderer/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/device_sensors/device_orientation_event_pump_unittest.cc

Issue 446603002: Refactor code listening to platform events in content/renderer/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webkitplatform_impl_start_stop

Patch Set: apply review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/renderer_gamepad_provider.h ('K') | « content/renderer/device_sensors/device_orientation_event_pump.cc ('k') | content/renderer/device_sensors/device_sensor_event_pump.h » ('j') | content/renderer/renderer_webkitplatformsupport_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/device_sensors/device_orientation_event_pump_unittest.cc

diff --git a/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc b/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc

index 95a54df07f9efaba0d577b27b3079763023e6475..54e1d98b65b5f6c749782bcc53295eb9c6b04927 100644

--- a/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc

+++ b/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc

@@ -46,14 +46,15 @@ class MockDeviceOrientationListener

class DeviceOrientationEventPumpForTesting : public DeviceOrientationEventPump {

public:

- DeviceOrientationEventPumpForTesting() { }

+ DeviceOrientationEventPumpForTesting()

+ : DeviceOrientationEventPump(0) { }

virtual ~DeviceOrientationEventPumpForTesting() { }

void OnDidStart(base::SharedMemoryHandle renderer_handle) {

DeviceOrientationEventPump::OnDidStart(renderer_handle);

}

- virtual bool SendStartMessage() OVERRIDE { return true; }

- virtual bool SendStopMessage() OVERRIDE { return true; }

+ virtual void SendStartMessage() OVERRIDE { }

+ virtual void SendStopMessage() OVERRIDE { }

virtual void FireEvent() OVERRIDE {

DeviceOrientationEventPump::FireEvent();

Stop();

@@ -121,7 +122,7 @@ TEST_F(DeviceOrientationEventPumpTest, DidStartPolling) {

base::MessageLoop loop;

InitBuffer();

- orientation_pump()->SetListener(listener());

+ orientation_pump()->Start(listener());

orientation_pump()->OnDidStart(handle());

base::MessageLoop::current()->Run();

@@ -141,7 +142,7 @@ TEST_F(DeviceOrientationEventPumpTest, FireAllNullEvent) {

base::MessageLoop loop;

InitBufferNoData();

- orientation_pump()->SetListener(listener());

+ orientation_pump()->Start(listener());

orientation_pump()->OnDidStart(handle());

base::MessageLoop::current()->Run();

@@ -158,7 +159,7 @@ TEST_F(DeviceOrientationEventPumpTest, UpdateRespectsOrientationThreshold) {

base::MessageLoop loop;

InitBuffer();

- orientation_pump()->SetListener(listener());

+ orientation_pump()->Start(listener());

orientation_pump()->OnDidStart(handle());

base::MessageLoop::current()->Run();