content/renderer/device_sensors/device_light_event_pump_unittest.cc - Issue 446603002: Refactor code listening to platform events in content/renderer/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/device_sensors/device_light_event_pump_unittest.cc

Issue 446603002: Refactor code listening to platform events in content/renderer/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webkitplatform_impl_start_stop

Patch Set: apply review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/renderer_gamepad_provider.h ('K') | « content/renderer/device_sensors/device_light_event_pump.cc ('k') | content/renderer/device_sensors/device_motion_event_pump.h » ('j') | content/renderer/renderer_webkitplatformsupport_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/device_sensors/device_light_event_pump_unittest.cc

diff --git a/content/renderer/device_sensors/device_light_event_pump_unittest.cc b/content/renderer/device_sensors/device_light_event_pump_unittest.cc

index 08182f7b1b48e5433f7f63cacb6c17e9f1214e0f..20a9e29b774d5f3413d73189ba07ea4fac6869ce 100644

--- a/content/renderer/device_sensors/device_light_event_pump_unittest.cc

+++ b/content/renderer/device_sensors/device_light_event_pump_unittest.cc

@@ -39,14 +39,15 @@ class MockDeviceLightListener : public blink::WebDeviceLightListener {

class DeviceLightEventPumpForTesting : public DeviceLightEventPump {

public:

- DeviceLightEventPumpForTesting() {}

+ DeviceLightEventPumpForTesting()

+ : DeviceLightEventPump(0) {}

virtual ~DeviceLightEventPumpForTesting() {}

void OnDidStart(base::SharedMemoryHandle renderer_handle) {

DeviceLightEventPump::OnDidStart(renderer_handle);

}

- virtual bool SendStartMessage() OVERRIDE { return true; }

- virtual bool SendStopMessage() OVERRIDE { return true; }

+ virtual void SendStartMessage() OVERRIDE { }

+ virtual void SendStopMessage() OVERRIDE { }

virtual void FireEvent() OVERRIDE {

DeviceLightEventPump::FireEvent();

Stop();

@@ -100,7 +101,7 @@ TEST_F(DeviceLightEventPumpTest, DidStartPolling) {

InitBuffer();

- light_pump()->SetListener(listener());

+ light_pump()->Start(listener());

light_pump()->OnDidStart(handle());

base::MessageLoop::current()->Run();

@@ -115,7 +116,7 @@ TEST_F(DeviceLightEventPumpTest, DidStartPollingValuesEqual) {

InitBuffer();

- light_pump()->SetListener(listener());

+ light_pump()->Start(listener());

light_pump()->OnDidStart(handle());

base::MessageLoop::current()->Run();