content/shell/renderer/test_runner/test_interfaces.h - Issue 446603002: Refactor code listening to platform events in content/renderer/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/test_interfaces.h

Issue 446603002: Refactor code listening to platform events in content/renderer/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webkitplatform_impl_start_stop

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/gamepad_controller.cc ('k') | content/shell/renderer/test_runner/test_interfaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/test_interfaces.h

diff --git a/content/shell/renderer/test_runner/test_interfaces.h b/content/shell/renderer/test_runner/test_interfaces.h

index 2edfda0abeb6e4cd0f395073b5a4143722a07cf6..8c2b048a06430b5f98f6408336380aabb45943cc 100644

--- a/content/shell/renderer/test_runner/test_interfaces.h

+++ b/content/shell/renderer/test_runner/test_interfaces.h

@@ -9,6 +9,7 @@

#include "base/basictypes.h"

#include "base/memory/scoped_ptr.h"

+#include "base/memory/weak_ptr.h"

#include "third_party/WebKit/public/platform/WebNonCopyable.h"

#if defined(OS_MACOSX)

@@ -62,7 +63,7 @@ class TestInterfaces {

private:

scoped_ptr<AccessibilityController> accessibility_controller_;

scoped_ptr<EventSender> event_sender_;

- scoped_ptr<GamepadController> gamepad_controller_;

+ base::WeakPtr<GamepadController> gamepad_controller_;

scoped_ptr<TextInputController> text_input_controller_;

scoped_ptr<TestRunner> test_runner_;

WebTestDelegate* delegate_;

« no previous file with comments | « content/shell/renderer/test_runner/gamepad_controller.cc ('k') | content/shell/renderer/test_runner/test_interfaces.cc » ('j') | no next file with comments »