Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: content/renderer/device_sensors/device_light_event_pump.h

Issue 446603002: Refactor code listening to platform events in content/renderer/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webkitplatform_impl_start_stop
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/device_sensors/device_light_event_pump.h
diff --git a/content/renderer/device_sensors/device_light_event_pump.h b/content/renderer/device_sensors/device_light_event_pump.h
index a998adffb3232554c72e0beb05c15e4d02e69e51..13b22b1b37e760970d36de86f81a7b9ff28b114e 100644
--- a/content/renderer/device_sensors/device_light_event_pump.h
+++ b/content/renderer/device_sensors/device_light_event_pump.h
@@ -19,27 +19,29 @@ namespace content {
typedef SharedMemorySeqLockReader<DeviceLightData>
DeviceLightSharedMemoryReader;
-class CONTENT_EXPORT DeviceLightEventPump : public DeviceSensorEventPump {
+class CONTENT_EXPORT DeviceLightEventPump
+ : public DeviceSensorEventPump<blink::WebDeviceLightListener> {
public:
- DeviceLightEventPump();
- explicit DeviceLightEventPump(int pump_delay_millis);
+ explicit DeviceLightEventPump(RenderThread* thread);
virtual ~DeviceLightEventPump();
// Sets the listener to receive updates for device light data at
// regular intervals. Returns true if the registration was successful.
bool SetListener(blink::WebDeviceLightListener* listener);
- // RenderProcessObserver implementation.
+ // PlatformEventObserver implementation.
virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
+ virtual void SendFakeDataForTesting(void* data) OVERRIDE;
protected:
// Methods overriden from base class DeviceSensorEventPump
virtual void FireEvent() OVERRIDE;
virtual bool InitializeReader(base::SharedMemoryHandle handle) OVERRIDE;
- virtual bool SendStartMessage() OVERRIDE;
- virtual bool SendStopMessage() OVERRIDE;
- blink::WebDeviceLightListener* listener_;
+ // PlatformEventObserver implementation.
+ virtual void SendStartMessage() OVERRIDE;
+ virtual void SendStopMessage() OVERRIDE;
+
scoped_ptr<DeviceLightSharedMemoryReader> reader_;
double last_seen_data_;

Powered by Google App Engine
This is Rietveld 408576698