Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2915)

Unified Diff: content/public/renderer/platform_event_observer.h

Issue 446603002: Refactor code listening to platform events in content/renderer/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webkitplatform_impl_start_stop
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/public/renderer/renderer_gamepad_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/platform_event_observer.h
diff --git a/content/public/renderer/platform_event_observer.h b/content/public/renderer/platform_event_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..a67cbec1a060e50220585be2cef13d9fae78552b
--- /dev/null
+++ b/content/public/renderer/platform_event_observer.h
@@ -0,0 +1,125 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_PLATFORM_EVENT_OBSERVER_H_
+#define CONTENT_PUBLIC_RENDERER_PLATFORM_EVENT_OBSERVER_H_
+
+#include "base/logging.h"
+#include "content/public/renderer/render_process_observer.h"
+#include "content/public/renderer/render_thread.h"
+
+namespace blink {
+class WebPlatformEventListener;
+}
+
+namespace content {
+
+// This class is used as a base class for PlatformEventObserver<ListenerType> to
+// allow storing PlatformEventObserver<> with different typename in the same
+// place.
+class PlatformEventObserverBase {
+ public:
+ virtual ~PlatformEventObserverBase() { }
+
+ // Methods that need to be exposed in PlatformEventObserverBase. Their purpose
+ // is described in PlatformEventObserver<>.
+
+ virtual void Start(blink::WebPlatformEventListener* listener) = 0;
+ virtual void Stop() = 0;
+
+ // Helper method that allows an sub-class to write its own test helper.
+ // The |data| type MUST be known from the caller.
+ virtual void SendFakeDataForTesting(void* data) { }
+};
+
+// PlatformEventObserver<> defines the basic skeleton for an object requesting
+// the browser process to start/stop listening to some platform/hardware events
+// and observe the result.
+// The results are received via IPC, assuming that the object was correctly
+// registered as an observer via the constructor taking a RenderThread.
+template <typename ListenerType>
+class PlatformEventObserver : public PlatformEventObserverBase,
+ public RenderProcessObserver {
+ public:
+ // Creates a PlatformEventObserver that doesn't listen to responses from the
+ // browser process. Can be used for testing purposes or for observers that
+ // have other means to get their results.
+ PlatformEventObserver()
+ : is_observing_(false),
+ listener_(0) {
+ }
+
+ // Creates a PlatformEventObserver that registers to the RenderThread in order
+ // to intercept the received IPC messages (via OnControlMessageReceived). If
+ // |thread| is null, it will not register.
+ explicit PlatformEventObserver(RenderThread* thread)
+ : is_observing_(false),
+ listener_(0) {
+ if (thread)
+ thread->AddObserver(this);
+ }
+
+ // The observer will automatically stop observing when destroyed in case it
+ // did not stop before.
+ virtual ~PlatformEventObserver() {
+ if (is_observing())
+ Stop();
+ }
+
+ // Called when a new IPC message is received. Must be used to listen to the
+ // responses from the browser process if any expected.
+ virtual bool OnControlMessageReceived(const IPC::Message& msg) OVERRIDE {
+ return false;
+ }
+
+ // Start observing. Will request the browser process to start listening to the
+ // events. |listener| will receive any response from the browser process.
+ // Note: should not be called if already observing.
+ virtual void Start(blink::WebPlatformEventListener* listener) {
+ DCHECK(!is_observing());
+ listener_ = static_cast<ListenerType*>(listener);
+ is_observing_ = true;
+
+ SendStartMessage();
+ }
+
+ // Stop observing. Will let the browser know that it doesn't need to observe
+ // anymore.
+ virtual void Stop() {
+ DCHECK(is_observing());
+ listener_ = 0;
+ is_observing_ = false;
+
+ SendStopMessage();
+ }
+
+ protected:
+ // This method is expected to send an IPC to the browser process to let it
+ // know that it should start observing.
+ // It is expected for subclasses to override it.
+ virtual void SendStartMessage() = 0;
+
+ // This method is expected to send an IPC to the browser process to let it
+ // know that it should start observing.
+ // It is expected for subclasses to override it.
+ virtual void SendStopMessage() = 0;
+
+ bool is_observing() const {
+ return is_observing_;
+ }
+
+ ListenerType* listener() {
+ return listener_;
+ }
+
+ private:
+ bool is_observing_;
+ ListenerType* listener_;
+
+ DISALLOW_COPY_AND_ASSIGN(PlatformEventObserver);
+};
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_RENDERER_PLATFORM_EVENT_OBSERVER_H_
« no previous file with comments | « content/content_renderer.gypi ('k') | content/public/renderer/renderer_gamepad_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698