Refactor code listening to platform events in content/renderer/.

content/renderer/device_sensors/device_orientation_event_pump_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device_orientation_event_pump.h"
 
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "content/common/device_sensors/device_orientation_hardware_buffer.h"
 #include "content/public/test/test_utils.h"
@@ skipping 28 matching lines @@
 
  private:
   bool did_change_device_orientation_;
   blink::WebDeviceOrientationData data_;
 
   DISALLOW_COPY_AND_ASSIGN(MockDeviceOrientationListener);
 };
 
 class DeviceOrientationEventPumpForTesting : public DeviceOrientationEventPump {
  public:
-  DeviceOrientationEventPumpForTesting() { }
+  DeviceOrientationEventPumpForTesting()
+      : DeviceOrientationEventPump(0) { }
   virtual ~DeviceOrientationEventPumpForTesting() { }
 
   void OnDidStart(base::SharedMemoryHandle renderer_handle) {
     DeviceOrientationEventPump::OnDidStart(renderer_handle);
   }
-  virtual bool SendStartMessage() OVERRIDE { return true; }
-  virtual bool SendStopMessage() OVERRIDE { return true; }
+  virtual void SendStartMessage() OVERRIDE { }
+  virtual void SendStopMessage() OVERRIDE { }
   virtual void FireEvent() OVERRIDE {
     DeviceOrientationEventPump::FireEvent();
     Stop();
     base::MessageLoop::current()->QuitWhenIdle();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DeviceOrientationEventPumpForTesting);
 };
 
@@ skipping 47 matching lines @@
   base::SharedMemory shared_memory_;
   DeviceOrientationHardwareBuffer* buffer_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceOrientationEventPumpTest);
 };
 
 TEST_F(DeviceOrientationEventPumpTest, DidStartPolling) {
   base::MessageLoop loop;
 
   InitBuffer();
-  orientation_pump()->SetListener(listener());
+  orientation_pump()->Start(listener());
   orientation_pump()->OnDidStart(handle());
 
   base::MessageLoop::current()->Run();
 
   const blink::WebDeviceOrientationData& received_data = listener()->data();
   EXPECT_TRUE(listener()->did_change_device_orientation());
   EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
   EXPECT_EQ(1, static_cast<double>(received_data.alpha));
   EXPECT_TRUE(received_data.hasAlpha);
   EXPECT_EQ(2, static_cast<double>(received_data.beta));
   EXPECT_TRUE(received_data.hasBeta);
   EXPECT_EQ(3, static_cast<double>(received_data.gamma));
   EXPECT_TRUE(received_data.hasGamma);
 }
 
 TEST_F(DeviceOrientationEventPumpTest, FireAllNullEvent) {
   base::MessageLoop loop;
 
   InitBufferNoData();
-  orientation_pump()->SetListener(listener());
+  orientation_pump()->Start(listener());
   orientation_pump()->OnDidStart(handle());
 
   base::MessageLoop::current()->Run();
 
   const blink::WebDeviceOrientationData& received_data = listener()->data();
   EXPECT_TRUE(listener()->did_change_device_orientation());
   EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
   EXPECT_FALSE(received_data.hasAlpha);
   EXPECT_FALSE(received_data.hasBeta);
   EXPECT_FALSE(received_data.hasGamma);
 }
 
 TEST_F(DeviceOrientationEventPumpTest, UpdateRespectsOrientationThreshold) {
   base::MessageLoop loop;
 
   InitBuffer();
-  orientation_pump()->SetListener(listener());
+  orientation_pump()->Start(listener());
   orientation_pump()->OnDidStart(handle());
 
   base::MessageLoop::current()->Run();
 
   const blink::WebDeviceOrientationData& received_data = listener()->data();
   EXPECT_TRUE(listener()->did_change_device_orientation());
   EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
   EXPECT_EQ(1, static_cast<double>(received_data.alpha));
   EXPECT_TRUE(received_data.hasAlpha);
   EXPECT_EQ(2, static_cast<double>(received_data.beta));
   EXPECT_TRUE(received_data.hasBeta);
   EXPECT_EQ(3, static_cast<double>(received_data.gamma));
   EXPECT_TRUE(received_data.hasGamma);
 
   buffer()->data.alpha =
       1 + DeviceOrientationEventPump::kOrientationThreshold / 2.0;
   listener()->set_did_change_device_orientation(false);
 
+  // Reset the pump's listener.
+  orientation_pump()->Start(listener());
+
   base::MessageLoop::current()->PostTask(FROM_HERE,
       base::Bind(&DeviceOrientationEventPumpForTesting::FireEvent,
                  base::Unretained(orientation_pump())));
   base::MessageLoop::current()->Run();
 
   EXPECT_FALSE(listener()->did_change_device_orientation());
   EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
   EXPECT_EQ(1, static_cast<double>(received_data.alpha));
   EXPECT_TRUE(received_data.hasAlpha);
   EXPECT_EQ(2, static_cast<double>(received_data.beta));
   EXPECT_TRUE(received_data.hasBeta);
   EXPECT_EQ(3, static_cast<double>(received_data.gamma));
   EXPECT_TRUE(received_data.hasGamma);
 
   buffer()->data.alpha =
       1 + DeviceOrientationEventPump::kOrientationThreshold;
   listener()->set_did_change_device_orientation(false);
 
+  // Reset the pump's listener.
+  orientation_pump()->Start(listener());
+
   base::MessageLoop::current()->PostTask(FROM_HERE,
       base::Bind(&DeviceOrientationEventPumpForTesting::FireEvent,
                  base::Unretained(orientation_pump())));
   base::MessageLoop::current()->Run();
 
   EXPECT_TRUE(listener()->did_change_device_orientation());
   EXPECT_EQ(1 + DeviceOrientationEventPump::kOrientationThreshold,
       static_cast<double>(received_data.alpha));
 }
 
 }  // namespace content