Added ASSERT(!document.childNeedsDistributionRecalc) to NodeRenderingTraversal::parent

Added ASSERT(!document.childNeedsDistributionRecalc) to NodeRenderingTraversal::parent

Assert is added inorder to ensure that the callers of
NodeRenderingTraversal::parent should do updateDistributionForNodeIfNeeded(...)
before using it.

Adding call updateDistributionForNodeIfNeeded(...) to ElementResolveContext
to avoid assertion failure.

BUG=338970

[deepak.sa, 2014-08-05 16:08:41]

PTAL?

[esprehn, 2014-08-06 17:16:37]

https://codereview.chromium.org/446593004/diff/1/Source/core/css/resolver/Ele...
File Source/core/css/resolver/ElementResolveContext.cpp (right):

https://codereview.chromium.org/446593004/diff/1/Source/core/css/resolver/Ele...
Source/core/css/resolver/ElementResolveContext.cpp:47:
element.document().updateDistributionForNodeIfNeeded(&element);
This isn't the right place for this, we should have already updated distribution
for the entire document at the start of recalcStyle which is where
ElementResolveContext is used.

What's the crash stack you're trying to fix?

[deepak.sa, 2014-08-07 11:27:42]

On 2014/08/06 17:16:37, esprehn wrote:
 
> What's the crash stack you're trying to fix?

These are the two layout tests that failing with ASSERT:

printing/page-format-data-display-none.html
virtual/threaded/printing/page-format-data-display-none.html


Both have the same call stack. Call Stack is as follows:


blink::NodeRenderingTraversal::parent(blink::Node const*,
blink::NodeRenderingTraversal::ParentDetails*)

blink::ElementResolveContext::ElementResolveContext(blink::Element&) 

blink::StyleResolverState::StyleResolverState(blink::Document&, blink::Element*,
blink::RenderStyle*) 

blink::StyleResolver::styleForPage(int) 

blink::Document::styleForPage(int)

blink::Document::pageSizeAndMarginsInPixels(int, blink::IntSize&, int&, int&,
int&, int&) 

blink::PrintContext::pageSizeAndMarginsInPixels(blink::LocalFrame*, int, int,
int, int, int, int, int) 

blink::Internals::pageSizeAndMarginsInPixels(int, int, int, int, int, int, int,
blink::ExceptionState&) const 

blink::InternalsV8Internal::pageSizeAndMarginsInPixelsMethod(v8::FunctionCallbackInfo<v8::Value>
const&) 

blink::InternalsV8Internal::pageSizeAndMarginsInPixelsMethodCallback(v8::FunctionCallbackInfo<v8::Value>
const&) 

v8::internal::FunctionCallbackArguments::Call(void
(*)(v8::FunctionCallbackInfo<v8::Value> const&)) 

v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**,
v8::internal::Isolate*)

[deepak.sa, 2014-08-11 13:41:10]

Ping!

[deepak.sa, 2014-08-13 10:55:00]

I have added the call stack you requested for. Please take a look.
Thanks!

[esprehn, 2014-08-16 08:05:42]

On 2014/08/13 at 10:55:00, deepak.sa wrote:
> I have added the call stack you requested for. Please take a look.
> Thanks!

I think hayato@ took care of this.

[deepak.sa, 2014-08-18 05:42:52]

On 2014/08/16 08:05:42, esprehn wrote:
> On 2014/08/13 at 10:55:00, deepak.sa wrote:
> > I have added the call stack you requested for. Please take a look.
> > Thanks!
> 
> I think hayato@ took care of this.

Ok! Thanks for the update.

This issue has been fixed here: https://codereview.chromium.org/448893003/