Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 446573002: Revert "Unbreak build with clang." (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Unbreak build with clang." This reverts commit r22878 and fixes the actual bug instead. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M build/standalone.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/types.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-05 14:17:44 UTC) #1
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-05 14:19:00 UTC) #2
Hannes Payer (out of office)
lgtm
6 years, 4 months ago (2014-08-05 14:19:05 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-05 14:19:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 22880 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698