Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: content/renderer/media/webrtc_uma_histograms.h

Issue 446553002: Add histogram WebRTC.UserMediaRequest.NoResultState to track user media requests with no result. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b399835
Patch Set: Comments addressed (and diffbase is now submitted, so diffing to master now) Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_uma_histograms.h
diff --git a/content/renderer/media/webrtc_uma_histograms.h b/content/renderer/media/webrtc_uma_histograms.h
index aee1f348740983ad5f0ef3e71957c0baebf0f1f6..4d5fb311374619863c0ebdfb27e6a4b0db4b3f9c 100644
--- a/content/renderer/media/webrtc_uma_histograms.h
+++ b/content/renderer/media/webrtc_uma_histograms.h
@@ -12,6 +12,20 @@
namespace content {
+// Used to investigate where UserMediaRequests end up.
+// Only UserMediaRequests that do not log with LogUserMediaRequestResult
+// should call LogUserMediaRequestWithNoResult.
+//
+// Elements in this enum should not be deleted or rearranged; the only permitted
+// operation is to add new elements to the end.
tommi (sloooow) - chröme 2014/08/06 11:42:21 to the end or before NUM_MEDIA_STREAM_REQUEST_WITH
andresp-chromium 2014/08/06 11:59:14 NUM_MEDIA_STREAM_REQUEST_WITH_NO_RESULT
+enum MediaStreamRequestState {
+ MEDIA_STREAM_REQUEST_EXPLICITLY_CANCELLED = 0,
tommi (sloooow) - chröme 2014/08/06 11:42:21 too much indent
andresp-chromium 2014/08/06 11:59:14 Done.
+ MEDIA_STREAM_REQUEST_NOT_GENERATED = 1,
+ MEDIA_STREAM_REQUEST_PENDING_MEDIA_TRACKS = 2,
+ NUM_MEDIA_STREAM_REQUEST_WITH_NO_RESULT
+};
+
+void LogUserMediaRequestWithNoResult(MediaStreamRequestState state);
void LogUserMediaRequestResult(MediaStreamRequestResult result);
// Helper enum used for histogramming calls to WebRTC APIs from JavaScript.

Powered by Google App Engine
This is Rietveld 408576698