content/renderer/media/webrtc_uma_histograms.h - Issue 446553002: Add histogram WebRTC.UserMediaRequest.NoResultState to track user media requests with no result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_uma_histograms.h

Issue 446553002: Add histogram WebRTC.UserMediaRequest.NoResultState to track user media requests with no result. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b399835

Patch Set: Addressed tommi comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_impl.cc ('K') | « content/renderer/media/media_stream_impl.cc ('k') | content/renderer/media/webrtc_uma_histograms.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_uma_histograms.h

diff --git a/content/renderer/media/webrtc_uma_histograms.h b/content/renderer/media/webrtc_uma_histograms.h

index aee1f348740983ad5f0ef3e71957c0baebf0f1f6..2ab6f6d65366821cf1fbec4108b465942ba7d10d 100644

--- a/content/renderer/media/webrtc_uma_histograms.h

+++ b/content/renderer/media/webrtc_uma_histograms.h

@@ -12,6 +12,21 @@

namespace content {

+// Used to investigate where UserMediaRequests end up.

+// Only UserMediaRequests that do not log with LogUserMediaRequestResult

+// should call LogUserMediaRequestWithNoResult.

+//

+// Elements in this enum should not be deleted or rearranged; the only

+// permitted operation is to add new elements before

+// NUM_MEDIA_STREAM_REQUEST_WITH_NO_RESULT.

+enum MediaStreamRequestState {

+ MEDIA_STREAM_REQUEST_EXPLICITLY_CANCELLED = 0,

+ MEDIA_STREAM_REQUEST_NOT_GENERATED = 1,

+ MEDIA_STREAM_REQUEST_PENDING_MEDIA_TRACKS = 2,

+ NUM_MEDIA_STREAM_REQUEST_WITH_NO_RESULT

+};

+void LogUserMediaRequestWithNoResult(MediaStreamRequestState state);

void LogUserMediaRequestResult(MediaStreamRequestResult result);

// Helper enum used for histogramming calls to WebRTC APIs from JavaScript.