Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 446553002: Add histogram WebRTC.UserMediaRequest.NoResultState to track user media requests with no result. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b399835
Patch Set: Addressed tommi comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index da56c703c7e572207146d1c8d89bbecf018e274f..8f5a43663dde71921fe089663c884a882d5dbacd 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -35770,6 +35770,20 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="WebRTC.UserMediaRequest.NoResultState"
+ enum="MediaStreamRequestState">
+ <owner>andresp@chromium.org</owner>
+ <summary>
+ The state of UserMediaRequests when it gets destroyed before having a
Mark P 2014/08/06 17:33:28 nit (singular plural mismatch; you didn't follow m
andresp-chromium 2014/08/06 18:00:22 Done.
+ result.
+
+ Note: &quot;Explicitly Cancelled&quot; means
+ MediaStreamImpl::cancelUserMediaRequest was called and not necessarily that
+ the user cancelled. Those are likely tracked as UserMediaRequest with a
+ result of permission denied.
+ </summary>
+</histogram>
+
<histogram name="WebRTC.UserMediaRequest.Result"
enum="MediaStreamRequestResult">
<owner>andresp@chromium.org</owner>
@@ -43247,6 +43261,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="8" label="Track Start Failure"/>
</enum>
+<enum name="MediaStreamRequestState" type="int">
+ <int value="0" label="Explicitly Cancelled"/>
+ <int value="1" label="Stream Not Generated"/>
+ <int value="2" label="Pending Media Tracks"/>
+</enum>
+
<enum name="MetaTagTypeEnum" type="int">
<int value="0" label="No viewport tag"/>
<int value="1" label="Viewport meta with device width"/>

Powered by Google App Engine
This is Rietveld 408576698