Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: src/ports/SkFontConfigParser_android.h

Issue 446473003: Parser for new fonts.xml format (Closed) Base URL: https://skia.googlesource.com/skia.git@fcparse-lmp-2
Patch Set: Derek's review Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ports/SkFontConfigParser_android.cpp » ('j') | tests/FontConfigParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkFontConfigParser_android.h
diff --git a/src/ports/SkFontConfigParser_android.h b/src/ports/SkFontConfigParser_android.h
index 8119fd7558e396161b89c9ba970df541cb133222..22e6f5fa6c08472a626771f53a751e99fe62a6c0 100644
--- a/src/ports/SkFontConfigParser_android.h
+++ b/src/ports/SkFontConfigParser_android.h
@@ -15,11 +15,12 @@
#include "SkTDArray.h"
struct FontFileInfo {
- FontFileInfo() : fIndex(0) { }
+ FontFileInfo() : fIndex(0), fWeight(0) { }
SkString fFileName;
int fIndex;
SkPaintOptionsAndroid fPaintOptions;
+ int fWeight;
};
/**
@@ -31,12 +32,17 @@ struct FontFileInfo {
* they are read from the configuration files.
*/
struct FontFamily {
- FontFamily() : fIsFallbackFont(false), order(-1) {}
+ FontFamily()
+ : fVariant(SkPaintOptionsAndroid::kDefault_Variant)
+ , order(-1)
+ , fIsFallbackFont(false) { }
- SkTArray<SkString> fNames;
- SkTArray<FontFileInfo> fFontFiles;
- bool fIsFallbackFont;
- int order; // only used internally by SkFontConfigParser
+ SkTArray<SkString> fNames;
+ SkTArray<FontFileInfo> fFontFiles;
+ SkString fLanguage;
+ SkPaintOptionsAndroid::FontVariant fVariant;
+ int order; // only used internally by SkFontConfigParser
+ bool fIsFallbackFont;
djsollen 2014/08/05 19:44:08 nit, why reorder fIsFallbackFont?
};
namespace SkFontConfigParser {
« no previous file with comments | « no previous file | src/ports/SkFontConfigParser_android.cpp » ('j') | tests/FontConfigParser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698