Issue 446383002: Make UserSelectionScreen::users_ private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 446383002: Make UserSelectionScreen::users_ private (Closed)

Created:
6 years, 4 months ago by bartfab (slow)

Modified:
6 years, 4 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make UserSelectionScreen::users_ private ChromeUserSelectionScreen::Init() used to access the |users_| member of its parent class even though it already knows the user list. This CL removes the unnecessary access and marks |users_| as private. BUG=398511 TEST=No compilation errors Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288076

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/chromeos/login/screens/user_selection_screen.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

Hi Nikita, Please take a look. This addresses your comment from CL 427053002.

6 years, 4 months ago (2014-08-07 14:15:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/446383002/1

6 years, 4 months ago (2014-08-07 14:21:18 UTC) #3

Message was sent while issue was closed.

Change committed as 288076

Expand Messages | Collapse Messages