Issue 446363002: Add platform methods to check reserved IP addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 446363002: Add platform methods to check reserved IP addresses. (Closed)

Created:
6 years, 4 months ago by Mike West

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Add platform methods to check reserved IP addresses. This patch adds two methods to Platform which will allow us to improve mixed content checking by determining whether SecurityOrigins and URLs point to IP addresses that are reserved (e.g. 127.0.0.1, 192.168.0.1). BUG=378566 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179719

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	public/platform/Platform.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mike West

Hi Jochen! Can you stamp this 3-line change to Platform.h? rsleevi has LGTMd the chromium-side ...

6 years, 4 months ago (2014-08-07 09:14:13 UTC) #1

Mike West

Actually adding you, Jochen. 3 line patch. sleevi LGTM'd the Chromium side. Hopefully you approve ...

6 years, 4 months ago (2014-08-07 09:15:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/446363002/1

6 years, 4 months ago (2014-08-07 16:14:09 UTC) #5

Message was sent while issue was closed.

Change committed as 179719

Expand Messages | Collapse Messages