Gallery: Scroll images by two finger swipe on a track pad.

Gallery: Scroll images by two finger swipe on a track pad.

Two finger swipe on a track pad generates 'mouseweel' event.
The CL adds a handler for the event.

BUG=401310
TEST=on link

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288311

[hirono, 2014-08-07 08:31:50]

PTAL the CL? Thank you!

[mtomasz, 2014-08-08 00:21:01]

just nits

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1463: * @param {event} event Touch
event.
event -> Event

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1473: * @param {event} event Touch
event.
ditto

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1571: viewport.getOffsetX() +
event.wheelDeltaX,
Does it work with a wheel on a separate mouse?

[hirono, 2014-08-08 02:41:44]

Thank you!

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1463: * @param {event} event Touch
event.
On 2014/08/08 00:21:00, mtomasz wrote:
> event -> Event

Done.

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1473: * @param {event} event Touch
event.
On 2014/08/08 00:21:01, mtomasz wrote:
> ditto

Done.

https://codereview.chromium.org/446343002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1571: viewport.getOffsetX() +
event.wheelDeltaX,
On 2014/08/08 00:21:00, mtomasz wrote:
> Does it work with a wheel on a separate mouse?

Yes, when the photo is zoomed, the mouse wheel moves picture vertically. The
main purpose of adding the handler is for track pad, but I think the behavior of
mouse wheel on a separate mouse is also not strange.

[mtomasz, 2014-08-08 04:35:36]

lgtm!

[hirono, 2014-08-08 04:44:13]

The CQ bit was checked by hirono@chromium.org

[hirono, 2014-08-08 04:44:18]

On 2014/08/08 04:35:36, mtomasz wrote:
> lgtm!

Thank you!

[commit-bot: I haz the power, 2014-08-08 04:46:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/446343002/80001

[commit-bot: I haz the power, 2014-08-08 06:14:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 10:31:52]

Change committed as 288311