Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.cc

Issue 446323002: ServiceWorker: Prevent worker script with incorrect MIME type to be registered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix browser tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_write_to_cache_job.cc
diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.cc b/content/browser/service_worker/service_worker_write_to_cache_job.cc
index b3e6cadfcb424aea3600d289059509ac2562d4fd..bd60ba0236dade532ea847d61de7f09171973470 100644
--- a/content/browser/service_worker/service_worker_write_to_cache_job.cc
+++ b/content/browser/service_worker/service_worker_write_to_cache_job.cc
@@ -301,6 +301,18 @@ void ServiceWorkerWriteToCacheJob::OnResponseStarted(
// response to our consumer, just don't cache it?
return;
}
+ // To prevent most user-uploaded content from being used as a serviceworker.
+ if (version_->script_url() == url_) {
+ std::string mime_type;
+ request->GetMimeType(&mime_type);
+ if (mime_type != "application/x-javascript" &&
+ mime_type != "text/javascript" &&
+ mime_type != "application/javascript") {
+ AsyncNotifyDoneHelper(net::URLRequestStatus(
+ net::URLRequestStatus::FAILED, net::ERR_FAILED));
+ return;
+ }
+ }
WriteHeadersToCache();
}
« no previous file with comments | « chrome/browser/chrome_service_worker_browsertest.cc ('k') | content/test/data/service_worker/fetch_event.js.mock-http-headers » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698