Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Side by Side Diff: net/quic/quic_config_test.cc

Issue 446283002: Include the socket receive buffer in the connection handshake. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@improve_SendAlgorithmSimulator_72332690
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_config.h" 5 #include "net/quic/quic_config.h"
6 6
7 #include "net/quic/crypto/crypto_handshake_message.h" 7 #include "net/quic/crypto/crypto_handshake_message.h"
8 #include "net/quic/crypto/crypto_protocol.h" 8 #include "net/quic/crypto/crypto_protocol.h"
9 #include "net/quic/quic_flags.h" 9 #include "net/quic/quic_flags.h"
10 #include "net/quic/quic_protocol.h" 10 #include "net/quic/quic_protocol.h"
(...skipping 24 matching lines...) Expand all
35 config_.SetDefaults(); 35 config_.SetDefaults();
36 config_.SetInitialFlowControlWindowToSend( 36 config_.SetInitialFlowControlWindowToSend(
37 kInitialSessionFlowControlWindowForTest); 37 kInitialSessionFlowControlWindowForTest);
38 config_.SetInitialStreamFlowControlWindowToSend( 38 config_.SetInitialStreamFlowControlWindowToSend(
39 kInitialStreamFlowControlWindowForTest); 39 kInitialStreamFlowControlWindowForTest);
40 config_.SetInitialSessionFlowControlWindowToSend( 40 config_.SetInitialSessionFlowControlWindowToSend(
41 kInitialSessionFlowControlWindowForTest); 41 kInitialSessionFlowControlWindowForTest);
42 config_.set_idle_connection_state_lifetime(QuicTime::Delta::FromSeconds(5), 42 config_.set_idle_connection_state_lifetime(QuicTime::Delta::FromSeconds(5),
43 QuicTime::Delta::FromSeconds(2)); 43 QuicTime::Delta::FromSeconds(2));
44 config_.set_max_streams_per_connection(4, 2); 44 config_.set_max_streams_per_connection(4, 2);
45 config_.SetSocketReceiveBufferToSend(kDefaultSocketReceiveBuffer);
45 CryptoHandshakeMessage msg; 46 CryptoHandshakeMessage msg;
46 config_.ToHandshakeMessage(&msg); 47 config_.ToHandshakeMessage(&msg);
47 48
48 uint32 value; 49 uint32 value;
49 QuicErrorCode error = msg.GetUint32(kICSL, &value); 50 QuicErrorCode error = msg.GetUint32(kICSL, &value);
50 EXPECT_EQ(QUIC_NO_ERROR, error); 51 EXPECT_EQ(QUIC_NO_ERROR, error);
51 EXPECT_EQ(5u, value); 52 EXPECT_EQ(5u, value);
52 53
53 error = msg.GetUint32(kMSPC, &value); 54 error = msg.GetUint32(kMSPC, &value);
54 EXPECT_EQ(QUIC_NO_ERROR, error); 55 EXPECT_EQ(QUIC_NO_ERROR, error);
55 EXPECT_EQ(4u, value); 56 EXPECT_EQ(4u, value);
56 57
57 error = msg.GetUint32(kIFCW, &value); 58 error = msg.GetUint32(kIFCW, &value);
58 EXPECT_EQ(QUIC_NO_ERROR, error); 59 EXPECT_EQ(QUIC_NO_ERROR, error);
59 EXPECT_EQ(kInitialSessionFlowControlWindowForTest, value); 60 EXPECT_EQ(kInitialSessionFlowControlWindowForTest, value);
60 61
61 error = msg.GetUint32(kSFCW, &value); 62 error = msg.GetUint32(kSFCW, &value);
62 EXPECT_EQ(QUIC_NO_ERROR, error); 63 EXPECT_EQ(QUIC_NO_ERROR, error);
63 EXPECT_EQ(kInitialStreamFlowControlWindowForTest, value); 64 EXPECT_EQ(kInitialStreamFlowControlWindowForTest, value);
64 65
65 error = msg.GetUint32(kCFCW, &value); 66 error = msg.GetUint32(kCFCW, &value);
66 EXPECT_EQ(QUIC_NO_ERROR, error); 67 EXPECT_EQ(QUIC_NO_ERROR, error);
67 EXPECT_EQ(kInitialSessionFlowControlWindowForTest, value); 68 EXPECT_EQ(kInitialSessionFlowControlWindowForTest, value);
68 69
70 error = msg.GetUint32(kSRBF, &value);
71 EXPECT_EQ(QUIC_NO_ERROR, error);
72 EXPECT_EQ(kDefaultSocketReceiveBuffer, value);
73
69 const QuicTag* out; 74 const QuicTag* out;
70 size_t out_len; 75 size_t out_len;
71 error = msg.GetTaglist(kCGST, &out, &out_len); 76 error = msg.GetTaglist(kCGST, &out, &out_len);
72 EXPECT_EQ(1u, out_len); 77 EXPECT_EQ(1u, out_len);
73 EXPECT_EQ(kQBIC, *out); 78 EXPECT_EQ(kQBIC, *out);
74 } 79 }
75 80
76 TEST_F(QuicConfigTest, ToHandshakeMessageWithPacing) { 81 TEST_F(QuicConfigTest, ToHandshakeMessageWithPacing) {
77 ValueRestore<bool> old_flag(&FLAGS_enable_quic_pacing, true); 82 ValueRestore<bool> old_flag(&FLAGS_enable_quic_pacing, true);
78 83
(...skipping 21 matching lines...) Expand all
100 client_config.set_max_streams_per_connection( 105 client_config.set_max_streams_per_connection(
101 2 * kDefaultMaxStreamsPerConnection, kDefaultMaxStreamsPerConnection); 106 2 * kDefaultMaxStreamsPerConnection, kDefaultMaxStreamsPerConnection);
102 client_config.SetInitialRoundTripTimeUsToSend( 107 client_config.SetInitialRoundTripTimeUsToSend(
103 10 * base::Time::kMicrosecondsPerMillisecond); 108 10 * base::Time::kMicrosecondsPerMillisecond);
104 client_config.SetInitialFlowControlWindowToSend( 109 client_config.SetInitialFlowControlWindowToSend(
105 2 * kInitialSessionFlowControlWindowForTest); 110 2 * kInitialSessionFlowControlWindowForTest);
106 client_config.SetInitialStreamFlowControlWindowToSend( 111 client_config.SetInitialStreamFlowControlWindowToSend(
107 2 * kInitialStreamFlowControlWindowForTest); 112 2 * kInitialStreamFlowControlWindowForTest);
108 client_config.SetInitialSessionFlowControlWindowToSend( 113 client_config.SetInitialSessionFlowControlWindowToSend(
109 2 * kInitialSessionFlowControlWindowForTest); 114 2 * kInitialSessionFlowControlWindowForTest);
115 client_config.SetSocketReceiveBufferToSend(kDefaultSocketReceiveBuffer);
110 QuicTagVector copt; 116 QuicTagVector copt;
111 copt.push_back(kTBBR); 117 copt.push_back(kTBBR);
112 copt.push_back(kFHDR); 118 copt.push_back(kFHDR);
113 client_config.SetConnectionOptionsToSend(copt); 119 client_config.SetConnectionOptionsToSend(copt);
114 CryptoHandshakeMessage msg; 120 CryptoHandshakeMessage msg;
115 client_config.ToHandshakeMessage(&msg); 121 client_config.ToHandshakeMessage(&msg);
116 string error_details; 122 string error_details;
117 const QuicErrorCode error = 123 const QuicErrorCode error =
118 config_.ProcessPeerHello(msg, CLIENT, &error_details); 124 config_.ProcessPeerHello(msg, CLIENT, &error_details);
119 EXPECT_EQ(QUIC_NO_ERROR, error); 125 EXPECT_EQ(QUIC_NO_ERROR, error);
(...skipping 10 matching lines...) Expand all
130 EXPECT_TRUE(config_.HasReceivedConnectionOptions()); 136 EXPECT_TRUE(config_.HasReceivedConnectionOptions());
131 EXPECT_EQ(2u, config_.ReceivedConnectionOptions().size()); 137 EXPECT_EQ(2u, config_.ReceivedConnectionOptions().size());
132 EXPECT_EQ(config_.ReceivedConnectionOptions()[0], kTBBR); 138 EXPECT_EQ(config_.ReceivedConnectionOptions()[0], kTBBR);
133 EXPECT_EQ(config_.ReceivedConnectionOptions()[1], kFHDR); 139 EXPECT_EQ(config_.ReceivedConnectionOptions()[1], kFHDR);
134 EXPECT_EQ(config_.ReceivedInitialFlowControlWindowBytes(), 140 EXPECT_EQ(config_.ReceivedInitialFlowControlWindowBytes(),
135 2 * kInitialSessionFlowControlWindowForTest); 141 2 * kInitialSessionFlowControlWindowForTest);
136 EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(), 142 EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(),
137 2 * kInitialStreamFlowControlWindowForTest); 143 2 * kInitialStreamFlowControlWindowForTest);
138 EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(), 144 EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(),
139 2 * kInitialSessionFlowControlWindowForTest); 145 2 * kInitialSessionFlowControlWindowForTest);
146 EXPECT_EQ(config_.ReceivedSocketReceiveBuffer(),
147 kDefaultSocketReceiveBuffer);
140 } 148 }
141 149
142 TEST_F(QuicConfigTest, ProcessServerHello) { 150 TEST_F(QuicConfigTest, ProcessServerHello) {
143 QuicConfig server_config; 151 QuicConfig server_config;
144 QuicTagVector cgst; 152 QuicTagVector cgst;
145 cgst.push_back(kQBIC); 153 cgst.push_back(kQBIC);
146 server_config.set_congestion_feedback(cgst, kQBIC); 154 server_config.set_congestion_feedback(cgst, kQBIC);
147 server_config.set_idle_connection_state_lifetime( 155 server_config.set_idle_connection_state_lifetime(
148 QuicTime::Delta::FromSeconds(kDefaultTimeoutSecs / 2), 156 QuicTime::Delta::FromSeconds(kDefaultTimeoutSecs / 2),
149 QuicTime::Delta::FromSeconds(kDefaultTimeoutSecs / 2)); 157 QuicTime::Delta::FromSeconds(kDefaultTimeoutSecs / 2));
150 server_config.set_max_streams_per_connection( 158 server_config.set_max_streams_per_connection(
151 kDefaultMaxStreamsPerConnection / 2, 159 kDefaultMaxStreamsPerConnection / 2,
152 kDefaultMaxStreamsPerConnection / 2); 160 kDefaultMaxStreamsPerConnection / 2);
153 server_config.SetInitialCongestionWindowToSend(kDefaultInitialWindow / 2); 161 server_config.SetInitialCongestionWindowToSend(kDefaultInitialWindow / 2);
154 server_config.SetInitialRoundTripTimeUsToSend( 162 server_config.SetInitialRoundTripTimeUsToSend(
155 10 * base::Time::kMicrosecondsPerMillisecond); 163 10 * base::Time::kMicrosecondsPerMillisecond);
156 server_config.SetInitialFlowControlWindowToSend( 164 server_config.SetInitialFlowControlWindowToSend(
157 2 * kInitialSessionFlowControlWindowForTest); 165 2 * kInitialSessionFlowControlWindowForTest);
158 server_config.SetInitialStreamFlowControlWindowToSend( 166 server_config.SetInitialStreamFlowControlWindowToSend(
159 2 * kInitialStreamFlowControlWindowForTest); 167 2 * kInitialStreamFlowControlWindowForTest);
160 server_config.SetInitialSessionFlowControlWindowToSend( 168 server_config.SetInitialSessionFlowControlWindowToSend(
161 2 * kInitialSessionFlowControlWindowForTest); 169 2 * kInitialSessionFlowControlWindowForTest);
170 server_config.SetSocketReceiveBufferToSend(kDefaultSocketReceiveBuffer);
162 CryptoHandshakeMessage msg; 171 CryptoHandshakeMessage msg;
163 server_config.ToHandshakeMessage(&msg); 172 server_config.ToHandshakeMessage(&msg);
164 string error_details; 173 string error_details;
165 const QuicErrorCode error = 174 const QuicErrorCode error =
166 config_.ProcessPeerHello(msg, SERVER, &error_details); 175 config_.ProcessPeerHello(msg, SERVER, &error_details);
167 EXPECT_EQ(QUIC_NO_ERROR, error); 176 EXPECT_EQ(QUIC_NO_ERROR, error);
168 EXPECT_TRUE(config_.negotiated()); 177 EXPECT_TRUE(config_.negotiated());
169 EXPECT_EQ(kQBIC, config_.congestion_feedback()); 178 EXPECT_EQ(kQBIC, config_.congestion_feedback());
170 EXPECT_EQ(QuicTime::Delta::FromSeconds(kDefaultTimeoutSecs / 2), 179 EXPECT_EQ(QuicTime::Delta::FromSeconds(kDefaultTimeoutSecs / 2),
171 config_.idle_connection_state_lifetime()); 180 config_.idle_connection_state_lifetime());
172 EXPECT_EQ(kDefaultMaxStreamsPerConnection / 2, 181 EXPECT_EQ(kDefaultMaxStreamsPerConnection / 2,
173 config_.max_streams_per_connection()); 182 config_.max_streams_per_connection());
174 EXPECT_EQ(kDefaultInitialWindow / 2, 183 EXPECT_EQ(kDefaultInitialWindow / 2,
175 config_.ReceivedInitialCongestionWindow()); 184 config_.ReceivedInitialCongestionWindow());
176 EXPECT_EQ(QuicTime::Delta::FromSeconds(0), config_.keepalive_timeout()); 185 EXPECT_EQ(QuicTime::Delta::FromSeconds(0), config_.keepalive_timeout());
177 EXPECT_EQ(10 * base::Time::kMicrosecondsPerMillisecond, 186 EXPECT_EQ(10 * base::Time::kMicrosecondsPerMillisecond,
178 config_.ReceivedInitialRoundTripTimeUs()); 187 config_.ReceivedInitialRoundTripTimeUs());
179 EXPECT_FALSE(config_.HasReceivedLossDetection()); 188 EXPECT_FALSE(config_.HasReceivedLossDetection());
180 EXPECT_EQ(config_.ReceivedInitialFlowControlWindowBytes(), 189 EXPECT_EQ(config_.ReceivedInitialFlowControlWindowBytes(),
181 2 * kInitialSessionFlowControlWindowForTest); 190 2 * kInitialSessionFlowControlWindowForTest);
182 EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(), 191 EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(),
183 2 * kInitialStreamFlowControlWindowForTest); 192 2 * kInitialStreamFlowControlWindowForTest);
184 EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(), 193 EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(),
185 2 * kInitialSessionFlowControlWindowForTest); 194 2 * kInitialSessionFlowControlWindowForTest);
195 EXPECT_EQ(config_.ReceivedSocketReceiveBuffer(),
196 kDefaultSocketReceiveBuffer);
186 } 197 }
187 198
188 TEST_F(QuicConfigTest, MissingOptionalValuesInCHLO) { 199 TEST_F(QuicConfigTest, MissingOptionalValuesInCHLO) {
189 CryptoHandshakeMessage msg; 200 CryptoHandshakeMessage msg;
190 msg.SetValue(kICSL, 1); 201 msg.SetValue(kICSL, 1);
191 msg.SetVector(kCGST, QuicTagVector(1, kQBIC)); 202 msg.SetVector(kCGST, QuicTagVector(1, kQBIC));
192 203
193 // Set all REQUIRED tags. 204 // Set all REQUIRED tags.
194 msg.SetValue(kICSL, 1); 205 msg.SetValue(kICSL, 1);
195 msg.SetVector(kCGST, QuicTagVector(1, kQBIC)); 206 msg.SetVector(kCGST, QuicTagVector(1, kQBIC));
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 EXPECT_DFATAL(config.SetInitialFlowControlWindowToSend(kInvalidWindow), 307 EXPECT_DFATAL(config.SetInitialFlowControlWindowToSend(kInvalidWindow),
297 "Initial flow control receive window"); 308 "Initial flow control receive window");
298 309
299 EXPECT_EQ(kDefaultFlowControlSendWindow, 310 EXPECT_EQ(kDefaultFlowControlSendWindow,
300 config.GetInitialFlowControlWindowToSend()); 311 config.GetInitialFlowControlWindowToSend());
301 } 312 }
302 313
303 } // namespace 314 } // namespace
304 } // namespace test 315 } // namespace test
305 } // namespace net 316 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_config.cc ('k') | net/quic/quic_protocol.h » ('j') | net/quic/quic_protocol.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698