[Android]: Fix tombstones.py architecture detection.

[Android]: Fix tombstones.py architecture detection.

This CL fixes tombstones.py architecture detection in two ways:
 - If the tombstone contains an ABI line, use this in preference to the devices
   default ABI, since some devices support multiple ABIs (e.g., 'arm' and 'arm64').
 - Map the abi to an arch which the stack tool accepts, e.g., armeabi-v7a -> arm, arm64-v8a -> arm64.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288072

[rmcilroy, 2014-08-07 11:53:57]

Sami, could you please take a look, thanks.

[rmcilroy, 2014-08-07 11:53:59]

Sami, could you please take a look, thanks.

[Sami, 2014-08-07 12:00:17]

Thanks Ross, lgtm with some tiny nits.

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py
File build/android/tombstones.py (right):

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:88: print 'Error: Unknown device ABI'
How about a more noisy and informative "raise RuntimeError('Unknown device ABI:
%s' % device_abi)"?

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:97: arch: the device architecture of tombstone data.
Can you document the new parameter here?

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:102: # Check if the tombstone data has am ABI
listed, if so use this in preference
s/am/an/

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:103: # to the devices default ABI.
s/devices/device's/

[rmcilroy, 2014-08-07 12:43:37]

Thanks Sami.

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py
File build/android/tombstones.py (right):

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:88: print 'Error: Unknown device ABI'
On 2014/08/07 12:00:17, Sami wrote:
> How about a more noisy and informative "raise RuntimeError('Unknown device
ABI:
> %s' % device_abi)"?

Done.

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:97: arch: the device architecture of tombstone data.
On 2014/08/07 12:00:17, Sami wrote:
> Can you document the new parameter here?

Done.

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:102: # Check if the tombstone data has am ABI
listed, if so use this in preference
On 2014/08/07 12:00:17, Sami wrote:
> s/am/an/

Done.

https://codereview.chromium.org/446273003/diff/1/build/android/tombstones.py#...
build/android/tombstones.py:103: # to the devices default ABI.
On 2014/08/07 12:00:17, Sami wrote:
> s/devices/device's/

Done.

[rmcilroy, 2014-08-07 12:45:04]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2014-08-07 12:46:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/446273003/20001

[commit-bot: I haz the power, 2014-08-07 16:22:55]

Change committed as 288072

[Kibeom Kim (inactive), 2014-08-07 17:17:15]

Thanks for fixing this!