Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 446243002: Clamp SkPictureShader's tile size. (Closed)

Created:
6 years, 4 months ago by f(malita)
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Clamp SkPictureShader's tile size. Blink used to clamp the max size for its pattern bitmaps (several SVG pattern tests rely on/verify this behavior). This CL clamps the maximum tile area to a reasonable value (16M pixels), and scales beyond that. R=reed@google.com,robertphillips@google.com,bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/bb204f4917aff10fcb65d29a2d96e53a9611c559

Patch Set 1 #

Patch Set 2 : updated comment (16M not 16K) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/core/SkPictureShader.cpp View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
f(malita)
6 years, 4 months ago (2014-08-07 00:46:14 UTC) #1
reed1
lgtm
6 years, 4 months ago (2014-08-07 12:58:27 UTC) #2
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 4 months ago (2014-08-07 15:30:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/446243002/20001
6 years, 4 months ago (2014-08-07 15:31:45 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 15:39:29 UTC) #5
Message was sent while issue was closed.
Change committed as bb204f4917aff10fcb65d29a2d96e53a9611c559

Powered by Google App Engine
This is Rietveld 408576698