Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: components/invalidation/sync_invalidation_listener.h

Issue 446223002: Remove WeakHandle from components/invalidation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/invalidation/sync_invalidation_listener.h
diff --git a/components/invalidation/sync_invalidation_listener.h b/components/invalidation/sync_invalidation_listener.h
index 647a04d543967701ed79817ceb08efadd62a1919..3efc4a1a32ce81a8b5d72e41f893f152f194573e 100644
--- a/components/invalidation/sync_invalidation_listener.h
+++ b/components/invalidation/sync_invalidation_listener.h
@@ -24,7 +24,6 @@
#include "components/invalidation/sync_system_resources.h"
#include "components/invalidation/unacked_invalidation_set.h"
#include "google/cacheinvalidation/include/invalidation-listener.h"
-#include "sync/internal_api/public/util/weak_handle.h"
namespace buzz {
class XmppTaskParentInterface;
@@ -76,10 +75,13 @@ class INVALIDATION_EXPORT_PRIVATE SyncInvalidationListener
void Start(
const CreateInvalidationClientCallback&
create_invalidation_client_callback,
- const std::string& client_id, const std::string& client_info,
+ const std::string& client_id,
+ const std::string& client_info,
const std::string& invalidation_bootstrap_data,
const UnackedInvalidationsMap& initial_object_states,
- const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker,
+ const base::WeakPtr<InvalidationStateTracker>& invalidation_state_tracker,
+ const scoped_refptr<base::SequencedTaskRunner>&
+ invalidation_state_tracker_task_runner,
Delegate* delegate);
void UpdateCredentials(const std::string& email, const std::string& token);
@@ -170,12 +172,14 @@ class INVALIDATION_EXPORT_PRIVATE SyncInvalidationListener
// Generate a Dictionary with all the debugging information.
scoped_ptr<base::DictionaryValue> CollectDebugData() const;
- WeakHandle<AckHandler> GetThisAsAckHandler();
+ base::WeakPtr<AckHandler> AsWeakPtr();
scoped_ptr<SyncNetworkChannel> sync_network_channel_;
SyncSystemResources sync_system_resources_;
UnackedInvalidationsMap unacked_invalidations_map_;
- WeakHandle<InvalidationStateTracker> invalidation_state_tracker_;
+ base::WeakPtr<InvalidationStateTracker> invalidation_state_tracker_;
+ scoped_refptr<base::SequencedTaskRunner>
+ invalidation_state_tracker_task_runner_;
Delegate* delegate_;
scoped_ptr<invalidation::InvalidationClient> invalidation_client_;
scoped_ptr<RegistrationManager> registration_manager_;
« no previous file with comments | « components/invalidation/non_blocking_invalidator.cc ('k') | components/invalidation/sync_invalidation_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698