[MIPS] Add ABI check for syscall numbers definitions

[MIPS] Add ABI check for syscall numbers definitions

In file mips_linux_syscalls.h are definitions of syscall
numbers for O32 ABI, so this check is needed in order for
Mips architectures with other ABIs to work properly.

BUG=400684
TEST=compile sandbox_linux_unittest for MIPS32 and MIPS64

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288252

[nedeljko, 2014-08-07 14:02:50]

Please have a look.

Thanks,
Nedeljko

[mdempsky, 2014-08-07 15:21:58]

https://codereview.chromium.org/446213003/diff/1/sandbox/linux/services/linux...
File sandbox/linux/services/linux_syscalls.h (right):

https://codereview.chromium.org/446213003/diff/1/sandbox/linux/services/linux...
sandbox/linux/services/linux_syscalls.h:25: #include
"sandbox/linux/services/mips_linux_syscalls.h"
Is there any plan to support other MIPS ABIs in the future?  Would it make sense
to rename this file to mips_o32_linux_syscalls.h or something at the same time,
or would you just extend mips_linux_syscalls.h to support both?

[mdempsky, 2014-08-07 15:26:56]

LGTM

Either way though, this CL LGTM as is.  I'm happy to punt on renaming the file
for when we actually want to add more ABI support if it's uncertain whether
we'll want to do that.

[petarj, 2014-08-07 15:37:48]

On 2014/08/07 15:21:58, mdempsky wrote:
>
https://codereview.chromium.org/446213003/diff/1/sandbox/linux/services/linux...
> File sandbox/linux/services/linux_syscalls.h (right):
> 
>
https://codereview.chromium.org/446213003/diff/1/sandbox/linux/services/linux...
> sandbox/linux/services/linux_syscalls.h:25: #include
> "sandbox/linux/services/mips_linux_syscalls.h"
> Is there any plan to support other MIPS ABIs in the future?

Yes, N64 ABI will follow. I suggest we discuss renaming at later point though,
once we have the patches for it.

[mdempsky, 2014-08-07 17:30:54]

On 2014/08/07 15:37:48, petarj wrote:
> Yes, N64 ABI will follow. I suggest we discuss renaming at later point though,
> once we have the patches for it.

SGTM

[nedeljko, 2014-08-07 19:44:47]

The CQ bit was checked by nedeljko.babic@imgtec.com

[commit-bot: I haz the power, 2014-08-07 19:57:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nedeljko.babic@imgtec.com/446213003/1

[commit-bot: I haz the power, 2014-08-07 23:23:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 00:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 00:53:40]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[nedeljko, 2014-08-08 08:11:53]

The CQ bit was checked by nedeljko.babic@imgtec.com

[commit-bot: I haz the power, 2014-08-08 08:15:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nedeljko.babic@imgtec.com/446213003/1

[commit-bot: I haz the power, 2014-08-08 08:22:16]

Change committed as 288252