scoped_refptr implicit conversion cleanup tool.

scoped_refptr implicit conversion cleanup tool.

Adapted from rsleevi's original patch. The initial version of the tool rewrites
all implicit conversions of scoped_refptr<T> to T*, even unsafe ones where a
temporary scoped_refptr<T> is assigned to a T*. A small tweak/hack has also
been added to run_tool.py to allow it to handle replacements that contain
embedded newlines.

BUG=110610
R=mdempsky@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288163

[dcheng, 2014-08-07 18:38:58]

I'm planning on making a few more updates to this tool before actually running
it, but I wanted to land the initial version to make changes more easily
reviewable.

- Properly rewrite unsafe assignments to change the type being assigned to,
rather than adding a call to get().
- Handling CHECK_EQ/CHECK_NE/ASSERT_EQ/ASSERT_NE/EXPECT_EQ/EXPECT_NE properly.
Right now, it tries to rewrite the guts of the helper function that supports
these macros. We need to match these separately.

[mdempsky, 2014-08-07 22:25:10]

https://codereview.chromium.org/446203003/diff/40001/tools/clang/rewrite_scop...
File tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp (right):

https://codereview.chromium.org/446203003/diff/40001/tools/clang/rewrite_scop...
tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp:54: if (const
clang::CXXOperatorCallExpr* op =
Might be worth adding a comment explaining that this test is checking for
operator overloading, except for foo(...) and foo[...] expressions that don't
need parentheses.

https://codereview.chromium.org/446203003/diff/40001/tools/clang/rewrite_scop...
tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp:136:
text.append("->get()");
Is it possible we'll NeedParens() here?  E.g., I think "**x" should be rewritten
as "(*x)->get()" instead of "*x->get()", but I don't know if that can actually
happen.

[dcheng, 2014-08-07 23:11:22]

https://codereview.chromium.org/446203003/diff/40001/tools/clang/rewrite_scop...
File tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp (right):

https://codereview.chromium.org/446203003/diff/40001/tools/clang/rewrite_scop...
tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp:54: if (const
clang::CXXOperatorCallExpr* op =
On 2014/08/07 22:25:10, mdempsky wrote:
> Might be worth adding a comment explaining that this test is checking for
> operator overloading, except for foo(...) and foo[...] expressions that don't
> need parentheses.

Done.

https://codereview.chromium.org/446203003/diff/40001/tools/clang/rewrite_scop...
tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp:136:
text.append("->get()");
On 2014/08/07 22:25:10, mdempsky wrote:
> Is it possible we'll NeedParens() here?  E.g., I think "**x" should be
rewritten
> as "(*x)->get()" instead of "*x->get()", but I don't know if that can actually
> happen.

Added a comment per our discussion.

[mdempsky, 2014-08-07 23:13:24]

lgtm

[Nico, 2014-08-07 23:37:33]

rslgtm

Maybe add tools/clang/rewrite_scoped_refptr/OWNERS containing you and mdempsky

[dcheng, 2014-08-07 23:40:37]

Committed patchset #4 manually as 288163 (presubmit successful).