Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 446193002: Remove dart:blink dependency on dart:html. This CL moves all of the (Closed)

Created:
6 years, 4 months ago by Leaf
Modified:
6 years, 4 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, ricow1, vsm
Visibility:
Public.

Description

Remove dart:blink dependency on dart:html. This CL moves all of the overload resolution (dependent on dart specific types) over to the dart:html side, along with the type resolution maps. This is a first step to generating dart:blink from the dartium idl. There is a paired blink CL which switches the type map lookup from dart:blink to dart:html. BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=38993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1022 lines, -1397 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 78 chunks +2 lines, -1130 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 70 chunks +722 lines, -82 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 3 chunks +27 lines, -3 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 7 chunks +87 lines, -11 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 4 chunks +72 lines, -4 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 3 chunks +8 lines, -27 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 4 chunks +11 lines, -27 lines 0 comments Download
M tools/dom/templates/html/dartium/_blink_dartium.darttemplate View 1 chunk +0 lines, -113 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 3 chunks +93 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Leaf
6 years, 4 months ago (2014-08-07 00:01:45 UTC) #1
Jacob
lgtm
6 years, 4 months ago (2014-08-07 00:16:04 UTC) #2
Leaf
6 years, 4 months ago (2014-08-07 16:12:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 38993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698