Don't pushState when setting the search page to itself.

Don't pushState when setting the search page to itself.

Calling pushState when the search page is shown causes history entries after
the current one to be lost.

This mimics the pre-r271538 behavior where it set location.hash. Setting
location.hash is a no-op (rather than pushing a duplicate history entry) if the
hash has not changed.

BUG=401004
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287892

[davidben, 2014-08-06 18:19:29]

The search page is screwy in lots of ways (loses the search when you press back)
that I suspect wants it to do a better job of keeping track when it's updating
its state from history and when its update history to match its state, but this
should at least fix this part.

[Dan Beam, 2014-08-06 18:34:03]

lgtm

https://codereview.chromium.org/446093002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/search_page.js (right):

https://codereview.chromium.org/446093002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/search_page.js:270: // Set the hash on the
current page, and the enclosing uber page. Only to
s/to/do/

[davidben, 2014-08-06 18:38:14]

https://codereview.chromium.org/446093002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/search_page.js (right):

https://codereview.chromium.org/446093002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/search_page.js:270: // Set the hash on the
current page, and the enclosing uber page. Only to
On 2014/08/06 18:34:03, Dan Beam wrote:
> s/to/do/

Done.

[davidben, 2014-08-06 19:37:07]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-08-06 19:37:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/446093002/20001

[commit-bot: I haz the power, 2014-08-06 23:15:02]

Change committed as 287892