Add ManagePasswordsBubbleBlacklistViewController and unit tests.

Add ManagePasswordsBubbleBlacklistViewController and unit tests.

BUG=328847
Committed: https://crrev.com/66919aa374b0ced447205733d3f68800cc4fd9a2
Cr-Commit-Position: refs/heads/master@{#291921}

[dconnelly, 2014-08-06 17:04:48]

Sorry for the deluge.

[Scott Hess - ex-Googler, 2014-08-22 21:42:55]

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm
(right):

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:30:
- (void)onDoneClicked {
As in the other cases, actions should be -actionName:(id)sender.  Ignore the
sender if you like (most actions do).

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:76:
password_manager::mac::ui::kDesiredBubbleWidth);
As with the pending view controller, I think |using namespace
password_manager::mac::ui;| is in order for this file.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm
(right):

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm:70:
[doneButton.target performSelector:doneButton.action];
As elsewhere, [doneButton performClick:nil];

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm:79:
[undoButton.target performSelector:undoButton.action];
Also here.

[dconnelly, 2014-08-25 10:54:17]

Sorry for the churn on this and the other one.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm
(right):

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:30:
- (void)onDoneClicked {
On 2014/08/22 21:42:55, Scott Hess wrote:
> As in the other cases, actions should be -actionName:(id)sender.  Ignore the
> sender if you like (most actions do).

Done.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:76:
password_manager::mac::ui::kDesiredBubbleWidth);
On 2014/08/22 21:42:55, Scott Hess wrote:
> As with the pending view controller, I think |using namespace
> password_manager::mac::ui;| is in order for this file.

Done.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm
(right):

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm:70:
[doneButton.target performSelector:doneButton.action];
On 2014/08/22 21:42:55, Scott Hess wrote:
> As elsewhere, [doneButton performClick:nil];

Done.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm:79:
[undoButton.target performSelector:undoButton.action];
On 2014/08/22 21:42:55, Scott Hess wrote:
> Also here.

Done.

[dconnelly, 2014-08-25 10:54:17]

Sorry for the churn on this and the other one.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm
(right):

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:30:
- (void)onDoneClicked {
On 2014/08/22 21:42:55, Scott Hess wrote:
> As in the other cases, actions should be -actionName:(id)sender.  Ignore the
> sender if you like (most actions do).

Done.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:76:
password_manager::mac::ui::kDesiredBubbleWidth);
On 2014/08/22 21:42:55, Scott Hess wrote:
> As with the pending view controller, I think |using namespace
> password_manager::mac::ui;| is in order for this file.

Done.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm
(right):

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm:70:
[doneButton.target performSelector:doneButton.action];
On 2014/08/22 21:42:55, Scott Hess wrote:
> As elsewhere, [doneButton performClick:nil];

Done.

https://codereview.chromium.org/446073002/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm:79:
[undoButton.target performSelector:undoButton.action];
On 2014/08/22 21:42:55, Scott Hess wrote:
> Also here.

Done.

[Scott Hess - ex-Googler, 2014-08-25 22:14:10]

LGTM, just consistent on how to call accessor.

https://codereview.chromium.org/446073002/diff/200001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm
(right):

https://codereview.chromium.org/446073002/diff/200001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:77:
std::max(NSWidth(titleLabel.frame), kDesiredBubbleWidth);
Randomly noticed titleLabel.frame versus [titleLabel frame].  As elsewhere,
either is fine, just be consistent.

https://codereview.chromium.org/446073002/diff/200001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:103:
curY = NSMaxY(explanationLabel.frame) + kUnrelatedControlVerticalPadding;
This .frame also.  Or [x frame] => x.frame, of course.

[dconnelly, 2014-08-26 09:12:59]

https://codereview.chromium.org/446073002/diff/200001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm
(right):

https://codereview.chromium.org/446073002/diff/200001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:77:
std::max(NSWidth(titleLabel.frame), kDesiredBubbleWidth);
On 2014/08/25 22:14:10, Scott Hess wrote:
> Randomly noticed titleLabel.frame versus [titleLabel frame].  As elsewhere,
> either is fine, just be consistent.

Done.

https://codereview.chromium.org/446073002/diff/200001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.mm:103:
curY = NSMaxY(explanationLabel.frame) + kUnrelatedControlVerticalPadding;
On 2014/08/25 22:14:10, Scott Hess wrote:
> This .frame also.  Or [x frame] => x.frame, of course.

Done.

[dconnelly, 2014-08-26 14:54:41]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-26 14:55:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/446073002/220001

[commit-bot: I haz the power, 2014-08-26 16:22:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46355)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-26 17:05:44]

Committed patchset #12 (220001) as 6de7eee62896176e469221ab790f016cafea4011

[commit-bot: I haz the power, 2014-09-10 02:43:24]

Patchset 12 (id:??) landed as
https://crrev.com/66919aa374b0ced447205733d3f68800cc4fd9a2
Cr-Commit-Position: refs/heads/master@{#291921}