Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 446063006: Add an #ifdef for a ChromeOS-only resource in WebUI. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
zel
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add an #ifdef for a ChromeOS-only resource in WebUI. BUG=333201 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
IDR_KEYBOARD_UTILS_JS should be CrOS-only. It only works right now due to a bug in grit, ...
6 years, 4 months ago (2014-08-06 23:49:32 UTC) #1
zel
lgtm
6 years, 4 months ago (2014-08-06 23:51:08 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-06 23:54:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/446063006/1
6 years, 4 months ago (2014-08-06 23:55:30 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 07:36:16 UTC) #5
Message was sent while issue was closed. 
Change committed as 287992

Powered by Google App Engine
This is Rietveld 408576698