Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/x87/macro-assembler-x87.cc

Issue 446003004: X87: Check that external references are registered in the serializer. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2997 matching lines...) Expand 10 before | Expand all | Expand 10 after
3008 3008
3009 3009
3010 void MacroAssembler::CheckPageFlagForMap( 3010 void MacroAssembler::CheckPageFlagForMap(
3011 Handle<Map> map, 3011 Handle<Map> map,
3012 int mask, 3012 int mask,
3013 Condition cc, 3013 Condition cc,
3014 Label* condition_met, 3014 Label* condition_met,
3015 Label::Distance condition_met_distance) { 3015 Label::Distance condition_met_distance) {
3016 DCHECK(cc == zero || cc == not_zero); 3016 DCHECK(cc == zero || cc == not_zero);
3017 Page* page = Page::FromAddress(map->address()); 3017 Page* page = Page::FromAddress(map->address());
3018 DCHECK(!serializer_enabled()); // Serializer cannot match page_flags.
3018 ExternalReference reference(ExternalReference::page_flags(page)); 3019 ExternalReference reference(ExternalReference::page_flags(page));
3019 // The inlined static address check of the page's flags relies 3020 // The inlined static address check of the page's flags relies
3020 // on maps never being compacted. 3021 // on maps never being compacted.
3021 DCHECK(!isolate()->heap()->mark_compact_collector()-> 3022 DCHECK(!isolate()->heap()->mark_compact_collector()->
3022 IsOnEvacuationCandidate(*map)); 3023 IsOnEvacuationCandidate(*map));
3023 if (mask < (1 << kBitsPerByte)) { 3024 if (mask < (1 << kBitsPerByte)) {
3024 test_b(Operand::StaticVariable(reference), static_cast<uint8_t>(mask)); 3025 test_b(Operand::StaticVariable(reference), static_cast<uint8_t>(mask));
3025 } else { 3026 } else {
3026 test(Operand::StaticVariable(reference), Immediate(mask)); 3027 test(Operand::StaticVariable(reference), Immediate(mask));
3027 } 3028 }
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
3317 if (ms.shift() > 0) sar(edx, ms.shift()); 3318 if (ms.shift() > 0) sar(edx, ms.shift());
3318 mov(eax, dividend); 3319 mov(eax, dividend);
3319 shr(eax, 31); 3320 shr(eax, 31);
3320 add(edx, eax); 3321 add(edx, eax);
3321 } 3322 }
3322 3323
3323 3324
3324 } } // namespace v8::internal 3325 } } // namespace v8::internal
3325 3326
3326 #endif // V8_TARGET_ARCH_X87 3327 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698