Issue 446003003: Call Enterfullscreen after player got initialized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 446003003: Call Enterfullscreen after player got initialized (Closed)

Created:
6 years, 4 months ago by qinmin

Modified:
6 years, 4 months ago

Reviewers:
xhwang

CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Call Enterfullscreen after player got initialized It is possible that Enterfullscreen() is called on an video element without src attribute. Then later on, when the player got initialized, we should let the player enter fullscreen. The current implementation calls Enterfullscreen first in video url cases. This will cause an issue that the BrowserMediaPlayerManager doesn't know which player to pass the surface to. As a result, we should delay EnterFullscreen() call until the player is initialized. And there is no point to ask a player to enterfullscreen if it is not created. BUG=400935 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288000

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	content/renderer/media/android/webmediaplayer_android.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/446003003/1

6 years, 4 months ago (2014-08-07 06:05:29 UTC) #4

Message was sent while issue was closed.

Change committed as 288000

Expand Messages | Collapse Messages