Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: components/bookmarks/browser/bookmark_utils_unittest.cc

Issue 446003002: Title: Same Bookmark url is getting pasted on the Bookmarkbar with same title. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments and test case added. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_utils_unittest.cc
diff --git a/components/bookmarks/browser/bookmark_utils_unittest.cc b/components/bookmarks/browser/bookmark_utils_unittest.cc
index be6aef6e9c6f4f7afb0cb58477dd1f05036c4a45..862b168d4469e6f55f5f2eeab6adafcd938a39ba 100644
--- a/components/bookmarks/browser/bookmark_utils_unittest.cc
+++ b/components/bookmarks/browser/bookmark_utils_unittest.cc
@@ -314,6 +314,41 @@ TEST_F(BookmarkUtilsTest, CopyPaste) {
EXPECT_FALSE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
}
+TEST_F(BookmarkUtilsTest, PasteSameBookmarkedURL) {
+ TestBookmarkClient client;
+ scoped_ptr<BookmarkModel> model(client.CreateModel());
+ const base::string16 url_text = ASCIIToUTF16("http://www.google.com/");
+ const base::string16 title_text = ASCIIToUTF16("foobar");
+ const base::string16 title_text_ = ASCIIToUTF16("foobar(1)");
+ const BookmarkNode* bookmark_bar_node = model->bookmark_bar_node();
+
+ // Adding a bookmark url in bookmark bar.
+ const BookmarkNode* node =
+ model->AddURL(bookmark_bar_node, 0, title_text, GURL(url_text));
+
+ EXPECT_EQ(url_text,
+ ASCIIToUTF16(bookmark_bar_node->GetChild(0)->url().spec()));
+ EXPECT_EQ(title_text, bookmark_bar_node->GetChild(0)->GetTitle());
+
+ // Copy a node to the clipboard.
+ std::vector<const BookmarkNode*> nodes;
+ nodes.push_back(node);
+ CopyToClipboard(model.get(), nodes, false);
+
+ // Now we should be able to paste from the clipboard.
+ EXPECT_TRUE(CanPasteFromClipboard(model.get(), bookmark_bar_node));
+
+ PasteFromClipboard(model.get(), bookmark_bar_node, 1);
+ ASSERT_EQ(2, bookmark_bar_node->child_count());
+
+ // Url for added node should be same as url_text.
+ EXPECT_EQ(url_text,
+ ASCIIToUTF16(bookmark_bar_node->GetChild(1)->url().spec()));
+ // Title for newly added node will have copied node title
+ // with numeric suffix.
+ EXPECT_EQ(title_text_, bookmark_bar_node->GetChild(1)->GetTitle());
+}
+
TEST_F(BookmarkUtilsTest, CopyPasteMetaInfo) {
TestBookmarkClient client;
scoped_ptr<BookmarkModel> model(client.CreateModel());

Powered by Google App Engine
This is Rietveld 408576698