Title: Same Bookmark url is getting pasted on the Bookmarkbar with same title.

components/bookmarks/browser/bookmark_model.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bookmarks/browser/bookmark_model.h"
 
 #include <algorithm>
 #include <functional>
 
 #include "base/bind.h"
@@ skipping 489 matching lines @@
                                   std::vector<const BookmarkNode*>* nodes) {
   base::AutoLock url_lock(url_lock_);
   BookmarkNode tmp_node(url);
   NodesOrderedByURLSet::iterator i = nodes_ordered_by_url_set_.find(&tmp_node);
   while (i != nodes_ordered_by_url_set_.end() && (*i)->url() == url) {
     nodes->push_back(*i);
     ++i;
   }
 }
 
+void BookmarkModel::GetNodesByURLAndTitle(

[sky, 2014/08/18 16:15:21]

There is no reason for this in BookmarkModel.

[Deepak, 2014/08/19 11:42:19]

we need this function so that I can make vector of titles and vector of the node
pointers that have the same parent as the node that I have copied ,and their
title is either same as the copied node or the starts with copied node title, As
I am distinguished node by adding some suffix with the node title.

I have made this function inline with the GetNodesByURL(), with some more
parameters based on requirment.So that nodes under a parent are distinguished.

If I am not doing this here then I have to do more processing in
PasteFromClipboard(), after getting the nodelist.so It is better I will do that
while making the node vector here itself.

[sky, 2014/08/19 16:38:31]

This function is only useful in one place and doesn't need internals of the
bookmarkmodel, it can get at all this via public api. There is no reason for it
here.

+    const GURL& url,
+    const base::string16& title,
+    const BookmarkNode* parent,
+    std::vector<const BookmarkNode*>* nodes,
+    std::vector<base::string16>* titles) {
+  base::AutoLock url_lock(url_lock_);
+  BookmarkNode tmp_node(url);
+  NodesOrderedByURLSet::iterator i = nodes_ordered_by_url_set_.find(&tmp_node);
+  while (i != nodes_ordered_by_url_set_.end() && (*i)->url() == url) {
+    if ((parent == (*i)->parent()) &&
+        (title == (*i)->GetTitle() ||
+         StartsWith((*i)->GetTitle(), title, false))) {

[sky, 2014/08/19 16:38:31]

The StartsWith logic makes no sense here.

+      titles->push_back((*i)->GetTitle());
+      nodes->push_back(*i);
+    }
+    ++i;
+  }
+}
+
 const BookmarkNode* BookmarkModel::GetMostRecentlyAddedUserNodeForURL(
     const GURL& url) {
   std::vector<const BookmarkNode*> nodes;
   GetNodesByURL(url, &nodes);
   std::sort(nodes.begin(), nodes.end(), &bookmarks::MoreRecentlyAdded);
 
   // Look for the first node that the user can edit.
   for (size_t i = 0; i < nodes.size(); ++i) {
     if (client_->CanBeEditedByUser(nodes[i]))
       return nodes[i];
@@ skipping 488 matching lines @@
   BookmarkPermanentNode* mobile_node =
       CreatePermanentNode(BookmarkNode::MOBILE);
   return scoped_ptr<BookmarkLoadDetails>(new BookmarkLoadDetails(
       bb_node,
       other_node,
       mobile_node,
       client_->GetLoadExtraNodesCallback(),
       new BookmarkIndex(client_, index_urls_, accept_languages),
       next_node_id_));
 }