Title: Same Bookmark url is getting pasted on the Bookmarkbar with same title.

components/bookmarks/browser/bookmark_utils.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bookmarks/browser/bookmark_utils.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/i18n/case_conversion.h"
 #include "base/i18n/string_search.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/prefs/pref_service.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "components/bookmarks/browser/bookmark_client.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/browser/scoped_group_bookmark_actions.h"
 #include "components/bookmarks/common/bookmark_pref_names.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/query_parser/query_parser.h"
 #include "net/base/net_util.h"
 #include "ui/base/models/tree_node_iterator.h"
@@ skipping 169 matching lines @@
   if (!parent)
     return;
 
   BookmarkNodeData bookmark_data;
   if (!bookmark_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE))
     return;
 
   if (index == -1)
     index = parent->child_count();
   ScopedGroupBookmarkActions group_paste(model);
+
+  if (bookmark_data.elements.size() == 1 &&
+      model->IsBookmarked(bookmark_data.elements[0].url)) {
+    std::vector<const BookmarkNode*> nodes;
+    std::vector<base::string16> titles;
+    std::vector<base::string16>::iterator it;
+    base::string16 newTitle = bookmark_data.elements[0].title;

[tfarina, 2014/08/13 13:40:52]

new_title

but, pointing this style issues is getting repetitive.

Please, take a moment to read
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml and
http://www.chromium.org/developers/coding-style

[Deepak, 2014/08/14 02:54:50]

Done.

+    model->GetNodesByURLAndTitle(bookmark_data.elements[0].url,
+                                 bookmark_data.elements[0].title,
+                                 parent,
+                                 &nodes,
+                                 &titles);
+    size_t i = 0;
+    it = std::find(titles.begin(), titles.end(), newTitle);
+    if (it == titles.end()) {
+      newTitle = bookmark_data.elements[0].title;
+    } else {
+      for (i = 0; i < nodes.size(); i++) {
+        newTitle = bookmark_data.elements[0].title +

[tfarina, 2014/08/13 13:40:52]

was this clang-formatted?

[Deepak, 2014/08/14 02:54:50]

yes , I have used git cl format for making it formatted.

+                   base::UTF8ToUTF16("-Copy(") + base::IntToString16(i + 1) +
+                   base::UTF8ToUTF16(")");
+        it = std::find(titles.begin(), titles.end(), newTitle);
+        if (it == titles.end())
+          break;
+      }
+    }
+    bookmark_data.elements[0].title = newTitle;
+  }
   CloneBookmarkNode(model, bookmark_data.elements, parent, index, true);
 }
 
 bool CanPasteFromClipboard(BookmarkModel* model, const BookmarkNode* node) {
   if (!node || !model->client()->CanBeEditedByUser(node))
     return false;
   return BookmarkNodeData::ClipboardContainsBookmarks();
 }
 
 std::vector<const BookmarkNode*> GetMostRecentlyModifiedUserFolders(
@@ skipping 223 matching lines @@
   }
   return false;
 }
 
 const BookmarkNode* GetBookmarkNodeByID(const BookmarkModel* model, int64 id) {
   // TODO(sky): TreeNode needs a method that visits all nodes using a predicate.
   return GetNodeByID(model->root_node(), id);
 }
 
 }  // namespace bookmarks